Skip to content

fix: improve error handling/reporting and prevent premature exit in dev mode#434

Merged
chrispcampbell merged 8 commits into
mainfrom
chris/260-error-handling
Feb 23, 2024
Merged

fix: improve error handling/reporting and prevent premature exit in dev mode#434
chrispcampbell merged 8 commits into
mainfrom
chris/260-error-handling

Conversation

@chrispcampbell
Copy link
Copy Markdown
Contributor

Fixes #260

@ToddFincannonEI: The gory details are in the issue, but TL;DR this improves error handling in a number of areas to:

  1. add error handling in places where we didn't have it quite right (like in readDat) and
  2. avoid process.exit and instead allow errors to bubble up and get reported in a standard way

Copy link
Copy Markdown
Collaborator

@ToddFincannonEI ToddFincannonEI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved error handling is long overdue. I like what you've done here. I reviewed the changes in the compile package, since I am not that familiar with the new packages. Letting exceptions bubble up instead of calling process.exit() seems obvious in retrospect!

@chrispcampbell chrispcampbell merged commit 98ab523 into main Feb 23, 2024
@chrispcampbell chrispcampbell deleted the chris/260-error-handling branch February 23, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error handling in watch mode when dat file can't be read (or emcc fails)

2 participants