fix: improve error handling/reporting and prevent premature exit in dev mode#434
Merged
Conversation
Collaborator
ToddFincannonEI
left a comment
There was a problem hiding this comment.
Improved error handling is long overdue. I like what you've done here. I reviewed the changes in the compile package, since I am not that familiar with the new packages. Letting exceptions bubble up instead of calling process.exit() seems obvious in retrospect!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #260
@ToddFincannonEI: The gory details are in the issue, but TL;DR this improves error handling in a number of areas to:
readDat) andprocess.exitand instead allow errors to bubble up and get reported in a standard way