fix: make flatten command work when equations don't include continuation backslash#173
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172 (backslash issue)
Fixes #68 (add test case for flatten command)
This resolves an issue caused by the new Vensim 9.2 file format that affected the
sde flattencommand that we use for building En-ROADS. The fix shouldn't affect other behavior in the preprocessor or elsewhere, andflattenisn't yet a fully supported command in SDE anyway (still somewhat experimental). I've added a test case to our suite to verify, and also verified that En-ROADS builds successfully again after updating our mdl files to the Vensim 9.2 file format.@ToddFincannon: Since this issue was blocking our upgrade to the new format, I'm going to merge this shortly without the usual review, but please feel free to comment if you have time and spot anything incorrect.