fix: prevent memory leaks in fixed delay initialization#160
Merged
Conversation
ToddFincannon
changed the title
chrispcampbell
approved these changes
Nov 19, 2021
Contributor
chrispcampbell
left a comment
chrispcampbell
left a comment
There was a problem hiding this comment.
@ToddFincannon Looks good. Apologies for the delay in getting to this and other PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159
I made one other change in
vensim.cto make it possible to compile with gcc, which does not support UTF-8 source files like clang does. I had used clever μ and σ variable names in probability-related code. I replaced these withmuandsigmaand SDEverywhere C code compiled with gcc just fine.