Skip to content

fix: allow > 2 dimensions when generating Vensim array names#155

Merged
chrispcampbell merged 1 commit into
developfrom
todd/154-ndim-names
Oct 28, 2021
Merged

fix: allow > 2 dimensions when generating Vensim array names#155
chrispcampbell merged 1 commit into
developfrom
todd/154-ndim-names

Conversation

@ToddFincannon
Copy link
Copy Markdown
Collaborator

@ToddFincannon ToddFincannon commented Oct 28, 2021

Fixes #154

@ToddFincannon ToddFincannon added this to the 0.6.0 milestone Oct 28, 2021
@chrispcampbell chrispcampbell changed the title allow > 2 dimensions when generating Vensim array names fix: allow > 2 dimensions when generating Vensim array names Oct 28, 2021
Copy link
Copy Markdown
Contributor

@chrispcampbell chrispcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested with En-ROADS and found no issues.

@chrispcampbell chrispcampbell merged commit 6575ea9 into develop Oct 28, 2021
@chrispcampbell chrispcampbell deleted the todd/154-ndim-names branch October 28, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vensim name generation fails for arrays with > 2 dimensions

2 participants