fix: correct initialization of 2D arrays to allow dimensions with matching subscript names#101
Merged
Merged
Conversation
ToddFincannon
approved these changes
Aug 14, 2021
Collaborator
ToddFincannon
left a comment
There was a problem hiding this comment.
I'm surprised this Vensim syntax works, but clearly it does. Good to have it covered.
Contributor
Author
Yeah, there are a few places in the En-ROADS model where this sort of alias was used, so I guess it works in Vensim, and apparently also does in SDE though I didn't take the time to figure out how. I was tempted to change it to use the new alias syntax you added support for recently, but figured I'd leave it as is so that there's some amount of test coverage. |
This was referenced Sep 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84
This fixes an issue that we encountered when trying a newer version of the C-ROADS model. See issue for more details.
The previous code would generate incorrect index values in the loop (for example,
[i][i]instead of[i][j]) because it would look up the index of the subscript by name (and this would fail if the same subscript name appears in both dimensions). The new code looks up the index by position in the dimensions array rather than by name.I updated the existing
arrays_cnametest case with an example that caused SDE to fail, but now passes with the fix in place.