Skip to content

Commit 9785503

Browse files
authored
[CHORE] Remove unused legacy metadata reconcile in sysdb (#5765)
## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - collection configuration's try_from_config already handles legacy metadata reconciliation, and with schema enabled, this code path is no longer accessed. removing to remove code debt - New functionality - ... ## Test plan _How are these changes tested?_ - [x ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Migration plan _Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?_ ## Observability plan _What is the plan to instrument and monitor this change?_ ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
1 parent b4d8b0c commit 9785503

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

rust/sysdb/src/sysdb.rs

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ use chroma_types::{
2020
ListCollectionVersionsError, ListDatabasesError, ListDatabasesResponse, Metadata, ResetError,
2121
ResetResponse, ScheduleEntry, ScheduleEntryConversionError, SegmentFlushInfo,
2222
SegmentFlushInfoConversionError, SegmentUuid, UpdateCollectionError, UpdateTenantError,
23-
UpdateTenantResponse, VectorIndexConfiguration,
23+
UpdateTenantResponse,
2424
};
2525
use chroma_types::{
2626
AdvanceTaskError, AdvanceTaskResponse, BatchGetCollectionSoftDeleteStatusError,
@@ -295,17 +295,6 @@ impl SysDb {
295295
dimension: Option<i32>,
296296
get_or_create: bool,
297297
) -> Result<Collection, CreateCollectionError> {
298-
let configuration = match configuration {
299-
Some(mut config) => {
300-
let hnsw_params = config.get_hnsw_config_from_legacy_metadata(&metadata)?;
301-
if let Some(hnsw_params) = hnsw_params {
302-
config.vector_index = VectorIndexConfiguration::Hnsw(hnsw_params);
303-
}
304-
Some(config)
305-
}
306-
None => None,
307-
};
308-
309298
match self {
310299
SysDb::Grpc(grpc) => {
311300
grpc.create_collection(

0 commit comments

Comments
 (0)