Skip to content

Commit 24fc2d6

Browse files
authored
Allow dead_letter_policy params to be optional (#116)
Signed-off-by: Nghia Tran <[email protected]>
1 parent a764bc8 commit 24fc2d6

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

modules/cloudevent-trigger/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ No requirements.
9797
| Name | Description | Type | Default | Required |
9898
|------|-------------|------|---------|:--------:|
9999
| <a name="input_broker"></a> [broker](#input\_broker) | The name of the pubsub topic we are using as a broker. | `string` | n/a | yes |
100-
| <a name="input_dead_letter_policy"></a> [dead\_letter\_policy](#input\_dead\_letter\_policy) | The dead letter policy for the subscription. | <pre>object({<br> dead_letter_topic = string<br> max_delivery_attempts = number<br> })</pre> | <pre>{<br> "dead_letter_topic": null,<br> "max_delivery_attempts": 3<br>}</pre> | no |
100+
| <a name="input_dead_letter_policy"></a> [dead\_letter\_policy](#input\_dead\_letter\_policy) | The dead letter policy for the subscription. | <pre>object({<br> dead_letter_topic = optional(string, null)<br> max_delivery_attempts = optional(number, 3)<br> })</pre> | <pre>{<br> "dead_letter_topic": null,<br> "max_delivery_attempts": 3<br>}</pre> | no |
101101
| <a name="input_filter"></a> [filter](#input\_filter) | A Knative Trigger-style filter over the cloud event attributes. | `map(string)` | n/a | yes |
102102
| <a name="input_name"></a> [name](#input\_name) | n/a | `string` | n/a | yes |
103103
| <a name="input_private-service"></a> [private-service](#input\_private-service) | The private cloud run service that is subscribing to these events. | <pre>object({<br> name = string<br> region = string<br> })</pre> | n/a | yes |

modules/cloudevent-trigger/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ variable "private-service" {
2727
variable "dead_letter_policy" {
2828
description = "The dead letter policy for the subscription."
2929
type = object({
30-
dead_letter_topic = string
31-
max_delivery_attempts = number
30+
dead_letter_topic = optional(string, null)
31+
max_delivery_attempts = optional(number, 3)
3232
})
3333
default = {
3434
dead_letter_topic = null

0 commit comments

Comments
 (0)