Skip to content

Conversation

@AlexV525
Copy link
Member

Fixes #1730.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@AlexV525 AlexV525 requested a review from a team as a code owner March 12, 2023 06:06
@AlexV525
Copy link
Member Author

An alternative change can be update the return type of CookieManager.getCookies from String to String?, but it should be considered as a breaking change, so the PR doesn't change that.

/// Merge cookies into a Cookie string.
static String getCookies(List<Cookie> cookies) {
return cookies.map((cookie) => '${cookie.name}=${cookie.value}').join('; ');
}

Copy link
Contributor

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

## 0.0.1 - 2019.9.17

* A cookie manager for Dio.
* A cookie manager for Dio.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@AlexV525 AlexV525 merged commit 12a00d1 into main Mar 12, 2023
@AlexV525 AlexV525 deleted the fix-cookie-header-empty-parse branch March 12, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Since cookie_manager 2.1.1 there is a empty cookie header attached

3 participants