Commit 1b9dfe1
committed
fix: expose ALPN in TLS handshake
New versions of gRPC-go are enforcing the `h2` ALPN to be presented
during the TLS handshake. See
https://pkg.go.dev/google.golang.org/grpc/internal/envconfig#pkg-variables
`GRPC_ENFORCE_ALPN_ENABLED`. The TLS server here isn't automatically
getting this set due to usage of GetConfigForClient.
This properly sets it.
Without this, istio-csr will be incompatible with Istio 1.24, which
upgrades the gRPC version. Note this can be worked around by setting
`GRPC_ENFORCE_ALPN_ENABLED=false` on the proxy container, which Istio is
able to do -- so there is an escape hatch for users.
The Istio logs look like
`"transport: authentication handshake failed: credentials: cannot check peer: missing selected ALPN property"`1 parent 48b06ca commit 1b9dfe1
1 file changed
+3
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
427 | 427 | | |
428 | 428 | | |
429 | 429 | | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
430 | 433 | | |
431 | 434 | | |
432 | 435 | | |
| |||
0 commit comments