Skip to content

Commit fa9bd23

Browse files
committed
Remove unused null_count field from OrcColumnStatistics (apache#146)
The null_count field was always hardcoded to -1 and never consumed. ORC statistics provide hasNull (boolean) but not a direct null count. Remove the dead field rather than keeping it for speculative future use.
1 parent 9feb359 commit fa9bd23

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

cpp/src/arrow/adapters/orc/adapter.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ Result<OrcColumnStatistics> ConvertColumnStatistics(
110110

111111
stats.has_null = orc_stats->hasNull();
112112
stats.num_values = static_cast<int64_t>(orc_stats->getNumberOfValues());
113-
stats.null_count = -1; // ORC doesn't provide null_count, only hasNull
114113
stats.has_min_max = false;
115114
stats.min = nullptr;
116115
stats.max = nullptr;

cpp/src/arrow/adapters/orc/adapter.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ namespace orc {
4343
struct OrcColumnStatistics {
4444
/// \brief Whether the column contains null values
4545
bool has_null;
46-
/// \brief Number of null values in the column (-1 if not available)
47-
int64_t null_count;
4846
/// \brief Total number of values in the column
4947
int64_t num_values;
5048
/// \brief Whether min/max statistics are available

0 commit comments

Comments
 (0)