From ef837440924361ae606b9fbe8c16e9c87d52c6eb Mon Sep 17 00:00:00 2001
From: Chris Naber <50926971+cwnaber@users.noreply.github.com>
Date: Tue, 27 Jan 2026 09:37:26 -0600
Subject: [PATCH 1/2] fix typo in variable name

---
 speech/gen_dataVals_from_wave_viewer.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/speech/gen_dataVals_from_wave_viewer.m b/speech/gen_dataVals_from_wave_viewer.m
index ccee774..6e2c6e9 100644
--- a/speech/gen_dataVals_from_wave_viewer.m
+++ b/speech/gen_dataVals_from_wave_viewer.m
@@ -341,7 +341,7 @@
 
 % find the index of ftrack_taxis that's closest to and greater than ampl_taxis's onset index
 [~, onsetIndFtrack] = find(sigmat.ftrack_taxis - sigmat.ampl_taxis(onsetIndAmp)>0, 1); 
-if ~isempty(onsetIndFrack)
+if ~isempty(onsetIndFtrack)
     offsetIndFtrack = find(ampl_Ftrack(onsetIndFtrack:end) < ampl_thresh4voicing);
 else
     offsetIndFtrack = [];

From bf9589dd7becff2300ebda9f97714b11afeb3c66 Mon Sep 17 00:00:00 2001
From: cwnaber <50926971+cwnaber@users.noreply.github.com>
Date: Mon, 9 Mar 2026 13:07:11 -0500
Subject: [PATCH 2/2] restrict onset index to within ftrack_taxis

---
 speech/gen_dataVals_from_wave_viewer.m | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/speech/gen_dataVals_from_wave_viewer.m b/speech/gen_dataVals_from_wave_viewer.m
index 6e2c6e9..724d8d0 100644
--- a/speech/gen_dataVals_from_wave_viewer.m
+++ b/speech/gen_dataVals_from_wave_viewer.m
@@ -302,10 +302,15 @@
     onset_type = 'default amplitude onset';
 end
 
+% find boundaries for onset detection. Only consider samples that could 
+%  have formants, ie, that exist in ftrack_taxis
+startIx = find(sigmat.ampl_taxis > sigmat.ftrack_taxis(1), 1);
+endIx = find(sigmat.ampl_taxis > sigmat.ftrack_taxis(end), 1) - 1; % subtracting 1 so endIx is inside the ftrack_taxis range
+
 % find onset
-onsetIndAmp = find(sigmat.ampl > ampl_thresh4voicing);
+onsetIndAmp = find(sigmat.ampl(startIx:endIx) > ampl_thresh4voicing);
 if onsetIndAmp
-    onsetIndAmp = onsetIndAmp(1) + 1;
+    onsetIndAmp = onsetIndAmp(1) + startIx;
 else
     onsetIndAmp = 1;
     onset_type = 'no amplitude onset found';