Few more python3 compatibility changes, PEP8 standard changes and add missing methods in PDDF common base APIs (sonic-net#7021)

#### Why I did it
- Python3 compatibility changes for PDDF eeprom class
- Adding API for temperature in PDDF psu class
- PEP8 standard changes and adding missing method in PDDF sfp class

#### How I did it
- Using python3 to invoke the sonic_platform module in PDDF based platform
- Running autopep8 tool to comply to PEP8 standards

Author: FuzailBrcm

platform/pddf/platform-api-pddf-base/sonic_platform_pddf_base/pddf_eeprom.py

@@ -6,7 +6,6 @@
 
 try:
     from sonic_eeprom import eeprom_tlvinfo
-    import binascii
 except ImportError as e:
     raise ImportError(str(e) + "- required module not found")
 
@@ -70,42 +69,42 @@ def serial_number_str(self):
         (is_valid, results) = self.get_tlv_field(self.eeprom_data, self._TLV_CODE_SERIAL_NUMBER)
         if not is_valid:
             return "N/A"
-        return results[2]
+        return results[2].decode('ascii')
 
     def base_mac_addr(self):
         (is_valid, t) = self.get_tlv_field(self.eeprom_data, self._TLV_CODE_MAC_BASE)
         if not is_valid or t[1] != 6:
             return super(TlvInfoDecoder, self).switchaddrstr(e)
 
-        return ":".join([binascii.b2a_hex(T) for T in t[2]])
+        return ":".join(["{:02x}".format(T) for T in t[2]]).upper()
 
     def modelstr(self):
         (is_valid, results) = self.get_tlv_field(self.eeprom_data, self._TLV_CODE_PRODUCT_NAME)
         if not is_valid:
             return "N/A"
 
-        return results[2]
+        return results[2].decode('ascii')
 
     def part_number_str(self):
         (is_valid, results) = self.get_tlv_field(self.eeprom_data, self._TLV_CODE_PART_NUMBER)
         if not is_valid:
             return "N/A"
 
-        return results[2]
+        return results[2].decode('ascii')
 
     def serial_str(self):
         (is_valid, results) = self.get_tlv_field(self.eeprom_data, self._TLV_CODE_SERVICE_TAG)
         if not is_valid:
             return "N/A"
 
-        return results[2]
+        return results[2].decode('ascii')
 
     def revision_str(self):
         (is_valid, results) = self.get_tlv_field(self.eeprom_data, self._TLV_CODE_DEVICE_VERSION)
         if not is_valid:
             return "N/A"
 
-        return results[2]
+        return results[2].decode('ascii')
 
     def system_eeprom_info(self):
         """

platform/pddf/platform-api-pddf-base/sonic_platform_pddf_base/pddf_psu.py

@@ -260,6 +260,24 @@ def get_status_led(self):
         color = self.pddf_obj.get_led_color()
         return (color)
 
+    def get_temperature(self):
+        """
+        Retrieves current temperature reading from PSU
+
+        Returns:
+            A float number of current temperature in Celsius up to nearest thousandth
+            of one degree Celsius, e.g. 30.125
+        """
+        device = "PSU{}".format(self.psu_index)
+        output = self.pddf_obj.get_attr_name_output(device, "psu_temp1_input")
+        if not output:
+            return 0.0
+
+        temp1 = output['status']
+
+        # temperature returned is in milli celcius
+        return float(temp1)/1000
+
     def get_input_voltage(self):
         """
         Retrieves current PSU input voltage

platform/pddf/platform-api-pddf-base/sonic_platform_pddf_base/pddf_sfp.py

@@ -83,7 +83,7 @@
 QSFP_MODULE_THRESHOLD_OFFSET = 128
 QSFP_MODULE_THRESHOLD_WIDTH = 24
 QSFP_CHANNEL_THRESHOLD_OFFSET = 176
-QSFP_CHANNEL_THRESHOLD_WIDTH = 16
+QSFP_CHANNEL_THRESHOLD_WIDTH = 24
 
 
 SFP_TEMPE_OFFSET = 96
@@ -94,8 +94,6 @@
 SFP_CHANNL_MON_WIDTH = 6
 SFP_MODULE_THRESHOLD_OFFSET = 0
 SFP_MODULE_THRESHOLD_WIDTH = 40
-SFP_CHANNL_THRESHOLD_OFFSET = 112
-SFP_CHANNL_THRESHOLD_WIDTH = 2
 SFP_STATUS_CONTROL_OFFSET = 110
 SFP_STATUS_CONTROL_WIDTH = 1
 SFP_TX_DISABLE_HARD_BIT = 7
@@ -327,16 +325,16 @@ def get_transceiver_info(self):
         else:
             xcvr_info_dict['type'] = sfp_type_data['data']['type']['value'] if sfp_type_data else 'N/A'
             xcvr_info_dict['type_abbrv_name'] = sfp_type_abbrv_name['data']['type_abbrv_name']['value'] \
-                    if sfp_type_abbrv_name else 'N/A'
+                if sfp_type_abbrv_name else 'N/A'
 
         xcvr_info_dict['manufacturer'] = sfp_vendor_name_data['data']['Vendor Name']['value'] \
-                if sfp_vendor_name_data else 'N/A'
+            if sfp_vendor_name_data else 'N/A'
         xcvr_info_dict['model'] = sfp_vendor_pn_data['data']['Vendor PN']['value'] if sfp_vendor_pn_data else 'N/A'
         xcvr_info_dict['hardware_rev'] = sfp_vendor_rev_data['data']['Vendor Rev']['value'] \
-                if sfp_vendor_rev_data else 'N/A'
+            if sfp_vendor_rev_data else 'N/A'
         xcvr_info_dict['serial'] = sfp_vendor_sn_data['data']['Vendor SN']['value'] if sfp_vendor_sn_data else 'N/A'
         xcvr_info_dict['vendor_oui'] = sfp_vendor_oui_data['data']['Vendor OUI']['value'] \
-                if sfp_vendor_oui_data else 'N/A'
+            if sfp_vendor_oui_data else 'N/A'
         xcvr_info_dict['vendor_date'] = sfp_vendor_date_data['data'][
             'VendorDataCode(YYYY-MM-DD Lot)']['value'] if sfp_vendor_date_data else 'N/A'
         xcvr_info_dict['cable_type'] = "Unknown"
@@ -351,7 +349,7 @@ def get_transceiver_info(self):
             for key in qsfp_compliance_code_tup:
                 if key in sfp_interface_bulk_data['data']['Specification compliance']['value']:
                     compliance_code_dict[key] = sfp_interface_bulk_data['data']['Specification compliance'][
-                            'value'][key]['value']
+                        'value'][key]['value']
             xcvr_info_dict['specification_compliance'] = str(compliance_code_dict)
 
             nkey = 'Nominal Bit Rate(100Mbs)'
@@ -371,7 +369,7 @@ def get_transceiver_info(self):
             for key in sfp_compliance_code_tup:
                 if key in sfp_interface_bulk_data['data']['Specification compliance']['value']:
                     compliance_code_dict[key] = sfp_interface_bulk_data['data']['Specification compliance'][
-                            'value'][key]['value']
+                        'value'][key]['value']
             xcvr_info_dict['specification_compliance'] = str(compliance_code_dict)
 
             xcvr_info_dict['nominal_bit_rate'] = str(
@@ -592,8 +590,9 @@ def get_transceiver_threshold_info(self):
             if sfpd_obj is None:
                 return None
 
-            dom_thres_raw = self.__read_eeprom_specific_bytes(QSFP_MODULE_THRESHOLD_OFFSET, QSFP_MODULE_THRESHOLD_WIDTH)
-
+            offset = 384
+            dom_thres_raw = self.__read_eeprom_specific_bytes(
+                (offset+QSFP_MODULE_THRESHOLD_OFFSET), QSFP_MODULE_THRESHOLD_WIDTH)
             if dom_thres_raw:
                 module_threshold_values = sfpd_obj.parse_module_threshold_values(
                     dom_thres_raw, 0)
@@ -608,8 +607,8 @@ def get_transceiver_threshold_info(self):
                     xcvr_dom_threshold_info_dict['vcchighwarning'] = module_threshold_data['VccHighWarning']['value']
                     xcvr_dom_threshold_info_dict['vcclowwarning'] = module_threshold_data['VccLowWarning']['value']
 
-            dom_thres_raw = self.__read_eeprom_specific_bytes(
-                QSFP_CHANNEL_THRESHOLD_OFFSET, QSFP_CHANNEL_THRESHOLD_WIDTH)
+            dom_thres_raw = self.__read_eeprom_specific_bytes((offset + QSFP_CHANNEL_THRESHOLD_OFFSET),
+                                                              QSFP_CHANNEL_THRESHOLD_WIDTH)
             if dom_thres_raw:
                 channel_threshold_values = sfpd_obj.parse_channel_threshold_values(
                     dom_thres_raw, 0)
@@ -659,15 +658,15 @@ def get_transceiver_threshold_info(self):
                 xcvr_dom_threshold_info_dict['txpowerhighalarm'] = dom_mod_th_data['data']['TXPowerHighAlarm']['value']
                 xcvr_dom_threshold_info_dict['txpowerlowalarm'] = dom_mod_th_data['data']['TXPowerLowAlarm']['value']
                 xcvr_dom_threshold_info_dict['txpowerhighwarning'] = dom_mod_th_data['data']['TXPowerHighWarning'][
-                        'value']
+                    'value']
                 xcvr_dom_threshold_info_dict['txpowerlowwarning'] = dom_mod_th_data['data']['TXPowerLowWarning'][
-                        'value']
+                    'value']
                 xcvr_dom_threshold_info_dict['rxpowerhighalarm'] = dom_mod_th_data['data']['RXPowerHighAlarm']['value']
                 xcvr_dom_threshold_info_dict['rxpowerlowalarm'] = dom_mod_th_data['data']['RXPowerLowAlarm']['value']
                 xcvr_dom_threshold_info_dict['rxpowerhighwarning'] = dom_mod_th_data['data']['RXPowerHighWarning'][
-                        'value']
+                    'value']
                 xcvr_dom_threshold_info_dict['rxpowerlowwarning'] = dom_mod_th_data['data']['RXPowerLowWarning'][
-                        'value']
+                    'value']
 
         return xcvr_dom_threshold_info_dict
 
@@ -764,7 +763,7 @@ def get_tx_fault(self):
                 tx_fault_list = []
                 dom_channel_monitor_raw = self.__read_eeprom_specific_bytes(
                     QSFP_CHANNL_TX_FAULT_STATUS_OFFSET, QSFP_CHANNL_TX_FAULT_STATUS_WIDTH) \
-                            if self.get_presence() else None
+                    if self.get_presence() else None
                 if dom_channel_monitor_raw is not None:
                     tx_fault_data = int(dom_channel_monitor_raw[0], 16)
                     tx_fault_list.append(tx_fault_data & 0x01 != 0)
@@ -1040,6 +1039,28 @@ def get_tx_power(self):
         else:
             return None
 
+    def get_intr_status(self):
+        """
+        Retrieves the interrupt status for this transceiver
+        Returns:
+            A Boolean, True if there is interrupt, False if not
+        """
+        intr_status = False
+
+        # Interrupt status can be checked for absent ports too
+        device = 'PORT{}'.format(self.port_index)
+        output = self.pddf_obj.get_attr_name_output(device, 'xcvr_intr_status')
+
+        if output:
+            status = int(output['status'].rstrip())
+
+            if status == 1:
+                intr_status = True
+            else:
+                intr_status = False
+
+        return intr_status
+
     def reset(self):
         """
         Reset SFP and return all user module settings to their default srate.
@@ -1354,6 +1375,8 @@ def get_presence(self):
         # if self.plugin_data doesn't specify anything regarding Transceivers
         if modpres == '1':
             return True
+        else:
+            return False
 
     def get_model(self):
         """