Fix (hopefully) last case where disp is negative and subtracted = true

Rot127 · Rot127 · commit 3d659dca58d3 · 2023-07-07T08:25:28.000-05:00
diff --git a/arch/ARM/ARMMapping.c b/arch/ARM/ARMMapping.c
@@ -1699,11 +1699,9 @@ void ARM_set_detail_op_mem(MCInst *MI, unsigned OpNum, bool is_index_reg,
 	}
 	case CS_OP_IMM: {
 		assert(secondary_type == CS_OP_IMM);
-		if (((int32_t) Val) < 0) {
-			ARM_get_detail_op(MI, 0)->mem.disp = -Val;
+		if (((int32_t) Val) < 0)
 			ARM_get_detail_op(MI, 0)->subtracted = true;
-		} else
-			ARM_get_detail_op(MI, 0)->mem.disp = Val;
+		ARM_get_detail_op(MI, 0)->mem.disp = Val;
 		break;
 	}
 	}

Original file line number	Diff line number	Diff line change
`@@ -1699,11 +1699,9 @@ void ARM_set_detail_op_mem(MCInst *MI, unsigned OpNum, bool is_index_reg,`
`1699`	`1699`	`}`
`1700`	`1700`	`case CS_OP_IMM: {`
`1701`	`1701`	`assert(secondary_type == CS_OP_IMM);`
`1702`		`- if (((int32_t) Val) < 0) {`
`1703`		`- ARM_get_detail_op(MI, 0)->mem.disp = -Val;`
	`1702`	`+ if (((int32_t) Val) < 0)`
`1704`	`1703`	`ARM_get_detail_op(MI, 0)->subtracted = true;`
`1705`		`- } else`
`1706`		`- ARM_get_detail_op(MI, 0)->mem.disp = Val;`
	`1704`	`+ ARM_get_detail_op(MI, 0)->mem.disp = Val;`
`1707`	`1705`	`break;`
`1708`	`1706`	`}`
`1709`	`1707`	`}`