Skip to content

call #to_s on remote so Pathnames don't go 💥 #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattbrictson merged 1 commit into from
Nov 13, 2017
Merged

call #to_s on remote so Pathnames don't go 💥 #410

mattbrictson merged 1 commit into from
Nov 13, 2017

Conversation

@UnderpantsGnome
Copy link
Contributor

@UnderpantsGnome UnderpantsGnome commented Nov 9, 2017

This fixes #409

@UnderpantsGnome UnderpantsGnome mentioned this pull request Nov 9, 2017
Closed
@sj26
Copy link
Contributor

sj26 commented Nov 9, 2017

Sorry, I didn't realise those methods accepted Pathname :-(

Perhaps we should also add a test to make sure this doesn't break again?

@UnderpantsGnome
Copy link
Contributor Author

UnderpantsGnome commented Nov 9, 2017

I can put together a test for this, but I don't have Vagrant installed and I don't really want to install it 😔

@UnderpantsGnome
Copy link
Contributor Author

UnderpantsGnome commented Nov 9, 2017

I added tests, the local one passes, I can't run the netssh one without vagrant. Let me know if this is good and if you want me to squash and update then CHANGELOG

@sj26
Copy link
Contributor

sj26 commented Nov 9, 2017

I've got it all set up, let me give it a quick go.

@sj26
Copy link
Contributor

sj26 commented Nov 9, 2017 

SSHKit::Backend::TestNetssh
  test_upload_string_io                                           PASS (1.05s)
  test_interaction_handler                                        PASS (0.01s)
  test_execute_raises_on_non_zero_exit_status_and_captures_stdout_and_stderr PASS (0.01s)
  test_test_does_not_raise_on_non_zero_exit_status                PASS (0.01s)
  test_capture                                                    PASS (0.01s)
  test_upload_and_then_capture_file_contents                      PASS (0.01s)
  test_upload_via_pathname                                        PASS (0.01s)
  test_simple_netssh                                              PASS (0.03s)
  test_env_vars_substituion_in_subshell                           PASS (0.01s)
  test_upload_within                                              PASS (0.02s)
  test_upload_large_file                                          PASS (9.27s)
:paranoid is deprecated, please use :verify_host_key. Supported values are exactly the same, only the name of the option has changed.
  test_ssh_option_merge                                           PASS (1.06s)

👍

@sj26
Copy link
Contributor

sj26 commented Nov 9, 2017 •
edited
Loading

(I just realised Travis also runs these and they all passed anyway.)

(Oh, no, not the functional tests... but they do pass locally.)

@mattbrictson
Copy link
Member

mattbrictson commented Nov 12, 2017 •
edited
Loading

Thanks for the quick turnaround on this! Could you add a CHANGELOG entry?

@UnderpantsGnome
Copy link
Contributor Author

UnderpantsGnome commented Nov 13, 2017

Updated the changelog and squashed commits. Not sure why Danger is blowing up.

@mattbrictson
Copy link
Member

mattbrictson commented Nov 13, 2017

Danger is blowing up because:

Please put the * Your contribution here! line back into CHANGELOG.md.

Could you take care of that? Thanks!

@UnderpantsGnome
Copy link
Contributor Author

UnderpantsGnome commented Nov 13, 2017

Ah Mondays... Danger is happy again.

@mattbrictson
Copy link
Member

mattbrictson commented Nov 13, 2017

Thanks for your help!

@mattbrictson mattbrictson merged commit 05a4322 into capistrano:master Nov 13, 2017
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 14, 2018
security/ruby-sshkit: update to 1.16.0
5379287 
## [1.16.0][] (2018-02-03)

  * [#417](capistrano/sshkit#417): Cache key generation for connections becomes slow when `known_hosts` is a valid `net/ssh` options and `known_hosts` file is big. This changes the cache key generation and fixes performance issue - [@ElvinEfendi](https://github.com/ElvinEfendi).
## [1.15.1][] (2017-11-18)

This is a small bug-fix release that fixes problems with `upload!` and `download!` that were inadvertently introduced in 1.15.0.

### Breaking changes

  * None

### Bug fixes

  * [#410](capistrano/sshkit#410): fix NoMethodError when using upload!/download! with Pathnames - [@UnderpantsGnome](https://github.com/UnderpantsGnome)
  * [#411](capistrano/sshkit#410): fix upload!/download! when using relative paths outside of `within` blocks -  [@Fjan](https://github.com/Fjan)

## [1.15.0][] (2017-11-03)

### New features

  * [#408](capistrano/sshkit#408): upload! and download! now respect `within` - [@sj26](https://github.com/sj26)

### Potentially breaking changes

  * `upload!` and `download!` now support remote paths which are
    relative to the `within` working directory. They were previously documented
    as only supporting absolute paths, but relative paths still worked relative
    to the remote working directory. If you rely on the previous behaviour you
    may need to adjust your code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@will-in-wi will-in-wi will-in-wi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Embrace String#start_with?" fails when called via Cap

4 participants

@UnderpantsGnome @sj26 @mattbrictson @will-in-wi