Skip to content

Commit b98acc3

Browse files
committed
fix(ios): remove duplication lines
1 parent 552d5ad commit b98acc3

File tree

1 file changed

+6
-21
lines changed

1 file changed

+6
-21
lines changed

ios/Sources/AdMobPlugin/Banner/BannerExecutor.swift

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ class BannerExecutor: NSObject, BannerViewDelegate {
128128
}
129129

130130
/// Tells the delegate an ad request loaded an ad.
131-
func bannerViewDidReceiveAd(_ bannerView: GADBannerView) {
131+
func bannerViewDidReceiveAd(_ bannerView: BannerView) {
132132
NSLog("bannerViewDidReceiveAd")
133133
if let rootViewController = plugin?.getRootVC() {
134134
rootViewController.view.addSubview(bannerView)
@@ -148,30 +148,15 @@ class BannerExecutor: NSObject, BannerViewDelegate {
148148
multiplier: 1,
149149
constant: 0)
150150
])
151-
}
152-
}
151+
self.plugin?.notifyListeners(BannerAdPluginEvents.SizeChanged.rawValue, data: [
152+
"width": bannerView.frame.width,
153+
"height": bannerView.frame.height
154+
])
155+
self.plugin?.notifyListeners(BannerAdPluginEvents.Loaded.rawValue, data: [:])
153156

154-
private func removeBannerViewToView() {
155-
if let rootViewController = plugin?.getRootVC() {
156-
if let subView = rootViewController.view.viewWithTag(2743243288699) {
157-
bannerView.delegate = nil
158-
NSLog("AdMob: find subView")
159-
subView.removeFromSuperview()
160-
}
161157
}
162158
}
163159

164-
/// Tells the delegate an ad request loaded an ad.
165-
func bannerViewDidReceiveAd(_ bannerView: BannerView) {
166-
NSLog("bannerViewDidReceiveAd")
167-
168-
self.plugin?.notifyListeners(BannerAdPluginEvents.SizeChanged.rawValue, data: [
169-
"width": bannerView.frame.width,
170-
"height": bannerView.frame.height
171-
])
172-
self.plugin?.notifyListeners(BannerAdPluginEvents.Loaded.rawValue, data: [:])
173-
}
174-
175160
/// Tells the delegate an ad request failed.
176161
func bannerView(_ bannerView: BannerView,
177162
didFailToReceiveAdWithError error: Error) {

0 commit comments

Comments
 (0)