Skip to content

Conversation

@valentindavid
Copy link
Contributor

No description provided.

@valentindavid valentindavid added Run nested The PR also runs tests inluded in nested suite FDE Marathon labels Dec 9, 2025
Copy link
Contributor

@ZeyadYasser ZeyadYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@ZeyadYasser ZeyadYasser added this to the 2.74 milestone Dec 9, 2025
@valentindavid valentindavid force-pushed the valentindavid/show-disk-model-plymouth branch from 15d9420 to b043219 Compare December 9, 2025 09:26
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Tue Dec 9 19:03:59 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/20059193376

Failures:

Preparing:

  • openstack-ps7:ubuntu-25.10-64:tests/main/interfaces-block-devices-zfs
  • openstack-ps7:ubuntu-24.04-64:tests/main/nvidia-files:535_server
  • openstack-ps7:ubuntu-22.04-64:tests/main/nvidia-files:470_server
  • google:ubuntu-14.04-64:
  • openstack-ps7:ubuntu-18.04-64:tests/regression/lp-1815869
  • openstack-ps7:ubuntu-16.04-64:tests/main/xdg-open-compat

Executing:

  • garden:ubuntu-22.04-64:tests/main/snapd-snap:lxd
  • openstack:opensuse-tumbleweed-selinux-64:tests/main/snap-quota-memory
  • openstack:opensuse-tumbleweed-selinux-64:tests/main/mount-dir-detect-check
  • openstack-arm-ps7:ubuntu-24.04-arm-64:tests/main/install-store-laaaarge
  • openstack-ps7:ubuntu-24.04-64:tests/main/mounts-persist-refresh-content-snap
  • openstack-ps7:ubuntu-24.04-64:tests/main/try
  • openstack-ps7:ubuntu-24.04-64:tests/main/snap-run-gdbserver:no_ip
  • openstack-ps7:ubuntu-18.04-64:tests/main/proxy-no-core

Restoring:

  • openstack:opensuse-tumbleweed-selinux-64:tests/main/interface-allow-auto-connection:true
  • openstack:opensuse-15.6-64:tests/main/snap-remove-not-mounted
  • openstack:opensuse-15.6-64:tests/main/interfaces-physical-memory-observe
  • openstack:opensuse-15.6-64:tests/main/
  • openstack:opensuse-15.6-64:
  • openstack:opensuse-15.6-64:tests/main/
  • openstack:opensuse-15.6-64:
  • openstack:opensuse-tumbleweed-selinux-64:tests/main/mount-dir-detect-check
  • openstack:opensuse-tumbleweed-selinux-64:tests/main/
  • openstack:opensuse-tumbleweed-selinux-64:
  • openstack-ps7:ubuntu-22.04-64:tests/main/nss-modules:winbind

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.47%. Comparing base (89b8d52) to head (64c9730).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
osutil/disks/mockdisk.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16355   +/-   ##
=======================================
  Coverage   77.46%   77.47%           
=======================================
  Files        1338     1335    -3     
  Lines      182865   182771   -94     
  Branches     2438     2438           
=======================================
- Hits       141663   141606   -57     
+ Misses      32610    32581   -29     
+ Partials     8592     8584    -8     
Flag Coverage Δ
unittests 77.47% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valentindavid valentindavid force-pushed the valentindavid/show-disk-model-plymouth branch from b043219 to 64c9730 Compare December 9, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FDE Marathon Run nested The PR also runs tests inluded in nested suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants