feat(MultiSelect): add scrollOverflow prop#1169
Merged
yurii-vasyliev merged 1 commit intocanonical:mainfrom Jan 15, 2025
Merged
feat(MultiSelect): add scrollOverflow prop#1169yurii-vasyliev merged 1 commit intocanonical:mainfrom
yurii-vasyliev merged 1 commit intocanonical:mainfrom
Conversation
Demo
Jenkins 
demos.haus 
Member
|
When I set scrollOverflow to true, scroll down, and select an item, the list is scrolled back to the top. Is that intended behavior? Screen.Recording.2025-01-14.at.19.00.14.mov |
Contributor
Author
|
@jmuzina , I don't think so, it seems like a bug. However, I think it's outside of the scope of this PR. |
jmuzina
added
Review: Percy +1
Review: QA +1
Review: Code +1
and removed
Review: Percy needed
Review: QA needed
labels
jmuzina
approved these changes
Jan 15, 2025
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
When used in certain cases with long lists, it would be useful to set the
scrollOverflow.I'd think we need this prop to be
trueall the time, but for the sake of compatibility with other projects, let's keep it false by default as it is right now.QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps
Percy steps
Fixes
Fixes: # .