Skip to content

Conversation

@ngocle2497
Copy link
Contributor

Overview

In prev-PR, i remove package from AndroidManifest.xml file, it drop support for RN <0.71.
Now, I check ANDROID_GRADLE_PLUGIN_VERSION to use namespace and remove package in AndroidManifest.xml file

Test Plan

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@Naturalclar Naturalclar merged commit 4cb35d9 into callstack:master Oct 6, 2023
@ngocle2497
Copy link
Contributor Author

i think we need to update like this

  if (supportsNamespace()) {
    namespace "com.org.reactnative.maskedview"

    sourceSets {
      main {
        manifest.srcFile "src/main/AndroidManifestNew.xml"
      }
    }
  }

@ngocle2497 ngocle2497 mentioned this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants