PHPStan level 8

Author: dereuromark

composer.json

@@ -64,7 +64,7 @@
         "rector-setup": "cp composer.json composer.backup && composer require --dev rector/rector:^0.7 && mv composer.backup composer.json",
         "stan": "phpstan analyse",
         "stan-rebuild-baseline": "phpstan analyse --configuration phpstan.neon --error-format baselineNeon src/ > phpstan-baseline.neon",
-        "stan-setup": "cp composer.json composer.backup && composer require --dev phpstan/phpstan:^1.0.0 psalm/phar:^5.0 && mv composer.backup composer.json",
+        "stan-setup": "cp composer.json composer.backup && composer require --dev phpstan/phpstan:^2.0.0 psalm/phar:^5.0 && mv composer.backup composer.json",
         "test": "phpunit --stderr"
     }
 }

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-	level: 6
+	level: 8
 	treatPhpDocTypesAsCertain: false
 	bootstrapFiles:
 		- tests/bootstrap.php

src/Validation/AuValidation.php

@@ -53,7 +53,7 @@ public static function postal(string $check): bool
      */
     public static function phone(string $check): bool
     {
-        $normalized = preg_replace('/(\s+|-|\(|\))/', '', preg_replace('/0011\s?61/', '+61', $check)); //remove spaces, parentheses and hyphens, convert full intl prefix.
+        $normalized = (string)preg_replace('/(\s+|-|\(|\))/', '', (string)preg_replace('/0011\s?61/', '+61', $check)); //remove spaces, parentheses and hyphens, convert full intl prefix.
         $pattern = '/^(((0|\+61)[2378])(\d){8}|((0|\+61)[45](\d){2}|1300|1800|190[02])(\d){6}|(\+61)?180(\d){4}|(\+61)?13\d{4}|(\+61)?12[2-8](\d){1,7}|(\+61|0)14[12357](\d){6})$/';
 
         return (bool)preg_match($pattern, $normalized);

src/Validation/BrValidation.php

@@ -192,7 +192,7 @@ public static function cnh(string $cnh): bool
      */
     public static function cns(string $cns): bool
     {
-        $cns = preg_replace('/[^0-9]/', '', $cns);
+        $cns = (string)preg_replace('/[^0-9]/', '', $cns);
 
         if (preg_match('/[1-2]\\d{10}00[0-1]\\d/', $cns) || preg_match('/[7-9]\\d{14}/', $cns)) {
             $len = strlen($cns);

src/Validation/FiValidation.php

@@ -85,6 +85,7 @@ public static function personId(string $check): bool
         }
         $list = array_values($list);
 
+        /** @phpstan-ignore-next-line */
         return $check[strlen($check) - 1] === $list[(int)(substr($check, 0, 6) . substr($check, 7, 3)) % 31];
     }
 

src/Validation/JpValidation.php

@@ -72,7 +72,7 @@ public static function phone(string $check): bool
      */
     public static function phoneDigits(string $check): bool
     {
-        $check = preg_replace(['/[\s\-]/', '/\+81/'], ['', '0'], $check);
+        $check = (string)preg_replace(['/[\s\-]/', '/\+81/'], ['', '0'], $check);
 
         $pattern = '/^0(?:[1-9]0\d{8}|[1-9]{2}\d{7})$/';
 

src/Validation/LocalizedValidation.php

@@ -103,6 +103,7 @@ public static function dateTime(string $string): bool
      */
     public static function decimal(string $string): bool
     {
+        /** @phpstan-ignore-next-line No-OP */
         return Number::parseFloat($string) !== false;
     }
 }