Make identifier parameter optional in AbstractAuthenticator

Default to null so authenticators that don't need an identifier
(like SessionAuthenticator) can be constructed without arguments.

Author: dereuromark

src/Authenticator/AbstractAuthenticator.php

@@ -52,7 +52,7 @@ abstract class AbstractAuthenticator implements AuthenticatorInterface
      * @param \Authentication\Identifier\IdentifierInterface|null $identifier Identifier instance.
      * @param array<string, mixed> $config Configuration settings.
      */
-    public function __construct(?IdentifierInterface $identifier, array $config = [])
+    public function __construct(?IdentifierInterface $identifier = null, array $config = [])
     {
         $this->_identifier = $identifier;
         $this->setConfig($config);

tests/TestCase/Authenticator/SessionAuthenticatorTest.php

@@ -74,7 +74,7 @@ public function testAuthenticateSuccess()
 
         $request = $request->withAttribute('session', $this->sessionMock);
 
-        $authenticator = new SessionAuthenticator(null);
+        $authenticator = new SessionAuthenticator();
         $result = $authenticator->authenticate($request);
 
         $this->assertInstanceOf(Result::class, $result);
@@ -97,7 +97,7 @@ public function testAuthenticateFailure()
 
         $request = $request->withAttribute('session', $this->sessionMock);
 
-        $authenticator = new SessionAuthenticator(null);
+        $authenticator = new SessionAuthenticator();
         $result = $authenticator->authenticate($request);
 
         $this->assertInstanceOf(Result::class, $result);
@@ -114,7 +114,7 @@ public function testPersistIdentity()
         $request = ServerRequestFactory::fromGlobals(['REQUEST_URI' => '/']);
         $request = $request->withAttribute('session', $this->sessionMock);
         $response = new Response();
-        $authenticator = new SessionAuthenticator(null);
+        $authenticator = new SessionAuthenticator();
 
         $data = new ArrayObject(['username' => 'florian']);
 
@@ -157,7 +157,7 @@ public function testClearIdentity()
         $request = $request->withAttribute('session', $this->sessionMock);
         $response = new Response();
 
-        $authenticator = new SessionAuthenticator(null);
+        $authenticator = new SessionAuthenticator();
 
         $this->sessionMock->expects($this->once())
             ->method('delete')
@@ -186,7 +186,7 @@ public function testImpersonate()
         $request = $request->withAttribute('session', $this->sessionMock);
         $response = new Response();
 
-        $authenticator = new SessionAuthenticator(null);
+        $authenticator = new SessionAuthenticator();
         $AuthUsers = TableRegistry::getTableLocator()->get('AuthUsers');
         $impersonator = $AuthUsers->newEntity([
             'username' => 'mariano',
@@ -225,7 +225,7 @@ public function testImpersonateAlreadyImpersonating()
         $request = $request->withAttribute('session', $this->sessionMock);
         $response = new Response();
 
-        $authenticator = new SessionAuthenticator(null);
+        $authenticator = new SessionAuthenticator();
         $impersonator = new ArrayObject([
             'username' => 'mariano',
             'password' => 'password',
@@ -259,7 +259,7 @@ public function testStopImpersonating()
         $request = $request->withAttribute('session', $this->sessionMock);
         $response = new Response();
 
-        $authenticator = new SessionAuthenticator(null);
+        $authenticator = new SessionAuthenticator();
 
         $impersonator = new ArrayObject([
             'username' => 'mariano',
@@ -306,7 +306,7 @@ public function testStopImpersonatingNotImpersonating()
         $request = $request->withAttribute('session', $this->sessionMock);
         $response = new Response();
 
-        $authenticator = new SessionAuthenticator(null);
+        $authenticator = new SessionAuthenticator();
 
         $this->sessionMock->expects($this->once())
             ->method('check')
@@ -343,7 +343,7 @@ public function testIsImpersonating()
         $request = ServerRequestFactory::fromGlobals(['REQUEST_URI' => '/']);
         $request = $request->withAttribute('session', $this->sessionMock);
 
-        $authenticator = new SessionAuthenticator(null);
+        $authenticator = new SessionAuthenticator();
 
         $this->sessionMock->expects($this->once())
             ->method('check')