Merge pull request #725 from cakephp/tests-deprecations

Fix deprecation warnings in tests.

Author: ADmad

docs/en/identity-object.rst

@@ -108,10 +108,9 @@ that implements the required interface::
    // Then pass it to the service configuration
    $service = new AuthenticationService([
        'identityClass' => $identityResolver,
-       'identifiers' => [
-           'Authentication.Password'
-       ],
        'authenticators' => [
-           'Authentication.Form'
+           'Authentication.Form' => [
+               'identifier' => 'Authentication.Password',
+           ],
        ]
    ]);

phpunit.xml.dist

@@ -3,6 +3,8 @@
          colors="true"
          processIsolation="false"
          stopOnFailure="false"
+         failOnDeprecation="true"
+         displayDetailsOnTestsThatTriggerDeprecations="true"
          cacheDirectory=".phpunit.cache"
          bootstrap="tests/bootstrap.php"
          xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.1/phpunit.xsd">

src/AuthenticationService.php

@@ -89,11 +89,10 @@ class AuthenticationService implements AuthenticationServiceInterface, Impersona
      * ```
      * $service = new AuthenticationService([
      *    'authenticators' => [
-     *        'Authentication.Form
+     *        'Authentication.Form' => [
+     *            'identifier' => 'Authentication.Password',
+     *        ],
      *    ],
-     *    'identifiers' => [
-     *        'Authentication.Password'
-     *    ]
      * ]);
      * ```
      *
@@ -172,7 +171,7 @@ public function loadIdentifier(string $name, array $config = []): IdentifierInte
     {
         deprecationWarning(
             '3.3.0',
-            'loadIdentifier() usage is deprecated. Directly pass Identifier to Authenticator.',
+            'loadIdentifier() usage is deprecated. Directly pass `\'identifier\'` config to the Authenticator.',
         );
 
         return $this->identifiers()->load($name, $config);

src/Authenticator/AuthenticatorCollection.php

@@ -46,7 +46,7 @@ public function __construct(IdentifierCollection $identifiers, array $config = [
         if ($identifiers->count() > 0) {
             deprecationWarning(
                 '3.3.0',
-                'loadIdentifier() usage is deprecated. Directly pass Identifier to Authenticator.',
+                'loadIdentifier() usage is deprecated. Directly pass `\'identifier\'` config to the Authenticator.',
             );
         }
 
@@ -70,7 +70,7 @@ protected function _create(object|string $class, string $alias, array $config):
             } else {
                 deprecationWarning(
                     '3.3.0',
-                    'loadIdentifier() usage is deprecated. Directly pass `\'identifier\'` config to Authenticator.',
+                    'loadIdentifier() usage is deprecated. Directly pass `\'identifier\'` config to the Authenticator.',
                 );
             }