Merge pull request #661 from AdmiringWorm/ignore-empty-splits

(maint) Add missing string split options

Author: gep13

.github/workflows/build.yaml

@@ -7,10 +7,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        # Only windows is possible until supported cake version
-        # is bumped to 0.37.0.0+.
-        # See https://github.com/cake-build/cake/issues/2695
-        os: [windows-latest]
+        os: [windows-latest, ubuntu-latest, macos-latest]
 
     steps:
       - uses: actions/[email protected]

.vscode/settings.json

@@ -39,5 +39,6 @@
     "vstest",
     "wixproj",
     "xbuild"
-  ]
+  ],
+  "powershell.codeFormatting.addWhitespaceAroundPipe": true
 }

Cake.Recipe/Content/buildPlatform.cake

@@ -203,7 +203,7 @@ public class LinuxBuildPlatform : BuildPlatform
 
         var lines = System.IO.File.ReadAllLines(file);
         var details = lines.Where(l => !string.IsNullOrEmpty(l))
-            .Select(l => l.Split('='))
+            .Select(l => l.Split(new [] {'=' }, StringSplitOptions.None))
             .Where(s => s.Length == 2)
             .ToDictionary(s => s[0].ToUpperInvariant(), s => s[1]);
 

Cake.Recipe/Content/email.cake

@@ -10,7 +10,7 @@ public void SendEmail(string subject, string message, string recipient, string s
 
     // The recipient parameter can contain a single email address or a comma/semi-colon separated list of email addresses
     var recipients = recipient
-        .Split(new[] { ',', ';' })
+        .Split(new[] { ',', ';' }, StringSplitOptions.None)
         .Select(emailAddress => new MailAddress(emailAddress))
         .ToArray();
 

Cake.Recipe/Content/testing.cake

@@ -119,11 +119,11 @@ BuildParameters.Tasks.DotNetCoreTestTask = Task("DotNetCore-Test")
         // It is problematic to merge the reports into one, as such we use a custom directory for coverage results
         CoverletOutputDirectory = BuildParameters.Paths.Directories.TestCoverage.Combine("coverlet"),
         CoverletOutputFormat    = CoverletOutputFormat.opencover,
-        ExcludeByFile           = ToolSettings.TestCoverageExcludeByFile.Split(';').ToList(),
-        ExcludeByAttribute      = ToolSettings.TestCoverageExcludeByAttribute.Split(';').ToList()
+        ExcludeByFile           = ToolSettings.TestCoverageExcludeByFile.Split(new [] {';' }, StringSplitOptions.None).ToList(),
+        ExcludeByAttribute      = ToolSettings.TestCoverageExcludeByAttribute.Split(new [] {';' }, StringSplitOptions.None).ToList()
     };
 
-    foreach (var filter in ToolSettings.TestCoverageFilter.Split(' '))
+    foreach (var filter in ToolSettings.TestCoverageFilter.Split(new [] {' ' }, StringSplitOptions.None))
     {
         if (filter[0] == '+')
         {