avoid string.Join(string.Empty

Author: SimonCropp

src/Cake.Common.Tests/Unit/Tools/MSBuild/MSBuildSettingsExtensionsTests.cs

@@ -184,7 +184,7 @@ public void Should_Set_Platform_Target_Via_Property()
 
                 // Then
                 Assert.True(settings.Properties.ContainsKey("Platform"));
-                Assert.Equal("Custom", string.Join(string.Empty, settings.Properties["Platform"]));
+                Assert.Equal("Custom", string.Concat(settings.Properties["Platform"]));
             }
 
             [Fact]

src/Cake.Common/Build/AzurePipelines/AzurePipelinesCommands.cs

@@ -318,7 +318,7 @@ private void WriteLoggingCommand(string actionName, string value)
 
         private void WriteLoggingCommand(string actionName, Dictionary<string, string> properties, string value)
         {
-            var props = string.Join(string.Empty, properties.Select(pair =>
+            var props = string.Concat(properties.Select(pair =>
             {
                 return string.Format(CultureInfo.InvariantCulture, "{0}={1};", pair.Key, pair.Value);
             }));

src/Cake.Core/Diagnostics/Formatting/FormatParser.cs

@@ -80,7 +80,7 @@ private static FormatToken ParseProperty(CharReader reader)
                     if (parts.Length > 1)
                     {
                         var name = parts[0];
-                        var format = string.Join(string.Empty, parts.Skip(1));
+                        var format = string.Concat(parts.Skip(1));
                         var positional = IsNumeric(name);
                         if (!positional)
                         {

src/Cake.Core/IO/Globbing/GlobTokenizer.cs

@@ -47,7 +47,7 @@ private static GlobTokenBuffer Tokenize(StringReader reader)
                         }
                         accumulator.Add(queue.Dequeue());
                     }
-                    result.Add(new GlobToken(GlobTokenKind.Text, string.Join(string.Empty, accumulator.Select(i => i.Value))));
+                    result.Add(new GlobToken(GlobTokenKind.Text, string.Concat(accumulator.Select(i => i.Value))));
                 }
                 else
                 {

src/Cake.Core/Scripting/CodeGen/ParameterEmitter.cs

@@ -30,7 +30,7 @@ internal sealed class ParameterEmitter
 
         internal static string Emit(ParameterInfo parameter, bool includeType)
         {
-            return string.Join(string.Empty, BuildParameterTokens(parameter, includeType));
+            return string.Concat(BuildParameterTokens(parameter, includeType));
         }
 
         private static IEnumerable<string> BuildParameterTokens(ParameterInfo parameter, bool includeType)