Skip to content

Commit e250478

Browse files
committed
fix: you should not update or restart services during a print
1 parent 694d472 commit e250478

3 files changed

Lines changed: 26 additions & 12 deletions

File tree

src/components/VersionStatus.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<span>indicates a detached head, not on master or an invalid origin</span>
3434
</v-tooltip>
3535

36-
<v-btn v-if="hasUpdate && (!dirty && valid)" :disabled="disabled" :loading="loading" x-small text color="warning" @click="$emit('on-update')">UPDATE</v-btn>
36+
<v-btn v-if="hasUpdate && !dirty && valid" :disabled="disabled" :loading="loading" x-small text color="warning" @click="$emit('on-update')">UPDATE</v-btn>
3737
</div>
3838
</template>
3939

src/components/widgets/SystemCommandsWidget.vue

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,25 @@
88
<v-list-item-title>Host</v-list-item-title>
99
</v-list-item-content>
1010
</template>
11-
<v-list-item @click="confirmRebootDialog.open = true">
11+
12+
<v-list-item
13+
@click="confirmRebootDialog.open = true"
14+
:disabled="printerPrinting">
1215
<v-list-item-title>Reboot</v-list-item-title>
1316
<v-list-item-icon>
14-
<v-icon>$powerCycle</v-icon>
17+
<v-icon color="error">$powerCycle</v-icon>
1518
</v-list-item-icon>
1619
</v-list-item>
17-
<v-list-item @click="confirmShutdownDialog.open = true">
20+
21+
<v-list-item
22+
@click="confirmShutdownDialog.open = true"
23+
:disabled="printerPrinting">
1824
<v-list-item-title>Shutdown</v-list-item-title>
1925
<v-list-item-icon>
20-
<v-icon>$power</v-icon>
26+
<v-icon color="error">$power</v-icon>
2127
</v-list-item-icon>
2228
</v-list-item>
29+
2330
</v-list-group>
2431
<v-list-group
2532
prepend-icon="$restart"
@@ -32,21 +39,28 @@
3239
<v-list-item @click="serviceRestartMoonraker">
3340
<v-list-item-title>Restart Moonraker</v-list-item-title>
3441
<v-list-item-icon>
35-
<v-icon>$restart</v-icon>
42+
<v-icon color="warning">$restart</v-icon>
3643
</v-list-item-icon>
3744
</v-list-item>
38-
<v-list-item @click="serviceRestartKlipper">
45+
46+
<v-list-item
47+
@click="serviceRestartKlipper"
48+
:disabled="printerPrinting">
3949
<v-list-item-title>Restart Klipper</v-list-item-title>
4050
<v-list-item-icon>
41-
<v-icon>$restart</v-icon>
51+
<v-icon color="error">$restartAlert</v-icon>
4252
</v-list-item-icon>
4353
</v-list-item>
44-
<v-list-item @click="serviceFirmwareRestartKlippy">
54+
55+
<v-list-item
56+
@click="serviceFirmwareRestartKlippy"
57+
:disabled="printerPrinting">
4558
<v-list-item-title>Restart MCU(s)</v-list-item-title>
4659
<v-list-item-icon>
47-
<v-icon>$restartAlert</v-icon>
60+
<v-icon color="error">$restartAlert</v-icon>
4861
</v-list-item-icon>
4962
</v-list-item>
63+
5064
<!-- <v-list-item @click="serverRestart">
5165
<v-list-item-title>Server Restart</v-list-item-title>
5266
<v-list-item-icon>

src/components/widgets/SystemVersionsWidget.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<v-list-item-action-text>
3232
<version-status
3333
:has-update="hasUpdate(i)"
34-
:disabled="hasWait(waits.onUpdate)"
34+
:disabled="hasWait(waits.onUpdate) || printerPrinting"
3535
:loading="hasWait(waits.onUpdate)"
3636
:dirty="(component.name) ? false : component.is_dirty"
3737
:valid="(component.name) ? true : component.is_valid"
@@ -44,7 +44,7 @@
4444

4545
<v-list-item class="v-list-item--x-dense">
4646
<v-list-item-content>
47-
<v-btn text outlined x-small @click="updateComponent('system')">update os packages</v-btn>
47+
<v-btn text outlined x-small :disabled="printerPrinting" @click="updateComponent('system')">update os packages</v-btn>
4848
</v-list-item-content>
4949
</v-list-item>
5050

0 commit comments

Comments
 (0)