Commit c4503d6
rbtree-avoid-generating-code-twice-for-the-cached-versions-checkpatch-fixes
WARNING: 'implemntation' may be misspelled - perhaps 'implementation'?
torvalds#8:
rb_leftmost was wired deeper into the implemntation, but there were some
ERROR: Macros with complex values should be enclosed in parentheses
torvalds#180: FILE: include/linux/rbtree.h:130:
+#define RB_ROOT_CACHED (struct rb_root_cached) { {NULL, }, NULL }
ERROR: Macros with complex values should be enclosed in parentheses
torvalds#183: FILE: include/linux/rbtree.h:133:
+#define rb_first_cached(root) (root)->rb_leftmost
ERROR: code indent should use tabs where possible
torvalds#197: FILE: include/linux/rbtree.h:147:
+ if (root->rb_leftmost == node)$
WARNING: please, no spaces at the start of a line
torvalds#197: FILE: include/linux/rbtree.h:147:
+ if (root->rb_leftmost == node)$
ERROR: code indent should use tabs where possible
torvalds#198: FILE: include/linux/rbtree.h:148:
+ root->rb_leftmost = rb_next(node);$
WARNING: please, no spaces at the start of a line
torvalds#198: FILE: include/linux/rbtree.h:148:
+ root->rb_leftmost = rb_next(node);$
total: 4 errors, 3 warnings, 246 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
./patches/rbtree-avoid-generating-code-twice-for-the-cached-versions.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Michel Lespinasse <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Stephen Rothwell <[email protected]>1 parent 5c0c57d commit c4503d6
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
147 | | - | |
148 | | - | |
| 147 | + | |
| 148 | + | |
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
| |||
0 commit comments