Skip to content

Commit d949374

Browse files
author
Peter Huene
authored
Remove wasmlink, wasmlink-cli, and test-modules. (#240)
This commit removes `wasmlink`, `wasmlink-cli`, and `test-modules` from the `wit-bindgen` repo. `wasmlink` is based on an outdated module linking proposal and predates any of the work on the component model. As such, it never really graduated beyond a useful demo of how multiple core WebAssembly modules might exchange interface types. Now that the work on the component model is progressing, the underlying wasm-tools no longer support the module linking proposal; therefore, `wasmlink` is becoming a maintenance burden. As the author of `wasmlink`, I think the time has come to remove it from the tree. Any parties that need a copy of `wasmlink` for whatever reason may fork it prior to this commit being merged.
1 parent de91e00 commit d949374

127 files changed

Lines changed: 7 additions & 11088 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/main.yml

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,6 @@ jobs:
7272
run: rustup update stable && rustup default stable && rustup component add rustfmt
7373
- name: Format source code
7474
run: cargo fmt -- --check
75-
- name: Format test module source code
76-
run: cargo fmt -- --check
77-
working-directory: crates/test-modules/modules
78-
- name: Format wasmlink runtime module source code
79-
run: cargo fmt -- --check
80-
working-directory: crates/wasmlink/runtime
8175

8276
demo:
8377
name: Build wit-bindgen demo
@@ -95,31 +89,3 @@ jobs:
9589
folder: static
9690
single-commit: true
9791
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
98-
99-
wasmlink-demo:
100-
name: Build wasmlink demo
101-
runs-on: ubuntu-latest
102-
env:
103-
WASMTIME_VERSION: 0.28.0
104-
steps:
105-
- uses: actions/checkout@v2
106-
- name: Download Wasmtime
107-
run: wget -nv 'https://github.com/bytecodealliance/wasmtime/releases/download/v${{ env.WASMTIME_VERSION }}/wasmtime-v${{ env.WASMTIME_VERSION }}-x86_64-linux.tar.xz' -O /tmp/wasmtime.tar.xz
108-
- name: Unpack Wasmtime
109-
run: |
110-
mkdir /tmp/wasmtime
111-
tar xvf /tmp/wasmtime.tar.xz --strip-components=1 -C /tmp/wasmtime
112-
- name: Install Rust
113-
run: rustup update stable --no-self-update && rustup default stable
114-
- name: Install wasm32-unknown-unknown target
115-
run: rustup target add wasm32-unknown-unknown
116-
- name: Install cargo-wasi
117-
run: cargo install cargo-wasi
118-
- name: Build the markdown component
119-
run: cargo wasi build --release --manifest-path crates/wasmlink/demo/markdown/Cargo.toml
120-
- name: Build the renderer component
121-
run: cargo wasi build --release --manifest-path crates/wasmlink/demo/renderer/Cargo.toml
122-
- name: Link the components
123-
run: cargo run --release -p wasmlink-cli -- -m markdown=crates/wasmlink/demo/markdown/target/wasm32-wasi/release/markdown.wasm -i markdown=crates/wasmlink/demo/markdown/markdown.wit -p wasmtime -o linked.wasm crates/wasmlink/demo/renderer/target/wasm32-wasi/release/renderer.wasm
124-
- name: Run the linked component with Wasmtime
125-
run: printf '# Hello\nworld' | /tmp/wasmtime/wasmtime --enable-module-linking --enable-multi-memory linked.wasm | grep -q '<h1>Hello</h1>'

Cargo.lock

Lines changed: 3 additions & 99 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@ edition = "2018"
88
members = [
99
"crates/test-rust-wasm",
1010
"crates/wit-bindgen-demo",
11-
"crates/wasmlink-cli",
1211
"crates/wit-component",
13-
"crates/test-modules",
1412
]
1513
resolver = "2"
1614

crates/parser/src/abi.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -795,12 +795,10 @@ pub enum LiftLower {
795795
/// the way the resulting bindings will be used by end users. See the comments
796796
/// on the `Direction` enum in gen-core for details.
797797
///
798-
/// The bindings ABI has a concept of a "guest" and a "host". Wasmlink can
799-
/// generate glue to bridge between two "guests", but in that case each side
800-
/// thinks of the glue as the "host". There are two variants of the ABI,
801-
/// one specialized for the "guest" importing and calling a function defined
802-
/// and exported in the "host", and the other specialized for the "host"
803-
/// importing and calling a fuinction defined and exported in the "guest".
798+
/// The bindings ABI has a concept of a "guest" and a "host". There are two
799+
/// variants of the ABI, one specialized for the "guest" importing and calling
800+
/// a function defined and exported in the "host", and the other specialized for
801+
/// the "host" importing and calling a function defined and exported in the "guest".
804802
#[derive(Clone, Copy, PartialEq, Eq, Debug)]
805803
pub enum AbiVariant {
806804
/// The guest is importing and calling the function.

crates/test-modules/Cargo.toml

Lines changed: 0 additions & 14 deletions
This file was deleted.

crates/test-modules/README.md

Lines changed: 0 additions & 4 deletions
This file was deleted.

crates/test-modules/build.rs

Lines changed: 0 additions & 38 deletions
This file was deleted.

0 commit comments

Comments
 (0)