[38.0.x] Prevent using shared memories with Memory
#12020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a few issues where it was possible to represent a wasm shared linear memory with the `wasmtime::Memory` type. This is not sound because `wasmtime::Memory` provides safe Rust access to the bytes where that is not possible with wasm shared memories. Shared memories in Rust must be represented by `SharedMemory`, not `wasmtime::Memory`. Specifically this commit prevents two vectors of this happening: 1. `Memory::new` now requires that the memory type specified is non-shared. Instead `SharedMemory::new` must be used instead. 2. Core dumps now skip over shared memories when iterating over all memories in the store. Supporting shared memories is a more invasive change and will happen on Wasmtime's `main` branch.
Member
Author
|
Carrying over @pchickey's approval from the security advisory. |
alexcrichton
merged commit 9ebb693
into
bytecodealliance:release-38.0.0
170 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a few issues where it was possible to represent a wasm shared linear memory with the
wasmtime::Memorytype. This is not sound becausewasmtime::Memoryprovides safe Rust access to the bytes where that is not possible with wasm shared memories. Shared memories in Rust must be represented bySharedMemory, notwasmtime::Memory.Specifically this commit prevents two vectors of this happening:
Memory::newnow requires that the memory type specified is non-shared. InsteadSharedMemory::newmust be used instead.Core dumps now skip over shared memories when iterating over all memories in the store. Supporting shared memories is a more invasive change and will happen on Wasmtime's
mainbranch.