s3: update timestamps in Contains() also #625
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the s3.update_timestamps option is enabled, we update the timestamp of any blob after it is successfully retried from the backend. We should do the same when checking for blob existence in the Contains() function. I don't think this is sufficient to make builds-without-the-bytes work with the s3 proxy backend when eviction is enabled, but it might help. Relates to buchgr#624.
mostynb
force-pushed
the
s3_update_timestamps_for_contains_also
branch
from
b1382dc to
2dc254f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the s3.update_timestamps option is enabled, we update the timestamp of any blob after it is successfully retried from the backend. We should do the same when checking for blob existence in the Contains() function.
I don't think this is sufficient to make builds-without-the-bytes work with the s3 proxy backend when eviction is enabled, but it might help.
Relates to #624.