Build: Add alias target for dependent project CMake consumption#143
Merged
Conversation
This naming convention is common in other CMake projects. The presence of `::` in the identifier results in fail-fast behavior; when a user calls `target_link_libraries` or similar, `nfd::nfd` MUST be an existing target at configure time, but `nfd` might have been a system library. As a result, the latter would appear to work until the linker fails to find a library by that name. This is not a breaking change - plain `nfd` is still accessible.
Owner
|
Thanks, this seems good! |
btzy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a target
nfd::nfdas an alias for the librarynfd.This naming convention is common in other CMake projects. The presence of
::in the identifier results in fail-fast behavior; when a user callstarget_link_librariesor similar,nfd::nfdMUST be an existing target at configure time, butnfdmight have been a system library. As a result, the latter would appear to work until the linker fails to find a library by that name.This is not a breaking change - plain
nfdis still accessible.