Skip to content

Commit 0460265

Browse files
cursoragentarsalann
andcommitted
fix: address lint issues in tests
- Replace context.Background() with t.Context() in tests - Replace assert.NoError with require.NoError for error assertions - Add t.Parallel() to all test functions - Fix import ordering with gci Co-authored-by: Arsalan <[email protected]>
1 parent 36acc6e commit 0460265

2 files changed

Lines changed: 18 additions & 11 deletions

File tree

pkg/python/uv.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import (
2626
)
2727

2828
var (
29-
ingestrInstallMutex sync.Mutex
29+
ingestrInstallMutex sync.Mutex
3030
ingestrInstalledPackages = make(map[string]bool)
3131
)
3232

pkg/python/uv_test.go

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010
"github.com/bruin-data/bruin/pkg/pipeline"
1111
"github.com/stretchr/testify/assert"
1212
"github.com/stretchr/testify/mock"
13+
"github.com/stretchr/testify/require"
1314
)
1415

1516
type mockUvInstaller struct {
@@ -169,13 +170,15 @@ func Test_buildIngestrPackageKey(t *testing.T) {
169170
t.Parallel()
170171

171172
u := &UvPythonRunner{}
172-
key := u.buildIngestrPackageKey(context.Background(), tt.extraPackages)
173+
key := u.buildIngestrPackageKey(t.Context(), tt.extraPackages)
173174
assert.Equal(t, tt.expected, key)
174175
})
175176
}
176177
}
177178

178179
func Test_ensureIngestrInstalled_OnlyInstallsOnce(t *testing.T) {
180+
t.Parallel()
181+
179182
ResetIngestrInstallCache()
180183
defer ResetIngestrInstallCache()
181184

@@ -198,22 +201,24 @@ func Test_ensureIngestrInstalled_OnlyInstallsOnce(t *testing.T) {
198201
binaryFullPath: "~/.bruin/uv",
199202
}
200203

201-
ctx := context.Background()
204+
ctx := t.Context()
202205
extraPackages := []string{"pyodbc"}
203206

204207
err := u.ensureIngestrInstalled(ctx, extraPackages, repo)
205-
assert.NoError(t, err)
208+
require.NoError(t, err)
206209

207210
err = u.ensureIngestrInstalled(ctx, extraPackages, repo)
208-
assert.NoError(t, err)
211+
require.NoError(t, err)
209212

210213
err = u.ensureIngestrInstalled(ctx, extraPackages, repo)
211-
assert.NoError(t, err)
214+
require.NoError(t, err)
212215

213216
assert.Equal(t, int32(1), installCount.Load(), "ingestr should only be installed once for the same package combination")
214217
}
215218

216219
func Test_ensureIngestrInstalled_InstallsForDifferentPackages(t *testing.T) {
220+
t.Parallel()
221+
217222
ResetIngestrInstallCache()
218223
defer ResetIngestrInstallCache()
219224

@@ -236,21 +241,23 @@ func Test_ensureIngestrInstalled_InstallsForDifferentPackages(t *testing.T) {
236241
binaryFullPath: "~/.bruin/uv",
237242
}
238243

239-
ctx := context.Background()
244+
ctx := t.Context()
240245

241246
err := u.ensureIngestrInstalled(ctx, []string{"pyodbc"}, repo)
242-
assert.NoError(t, err)
247+
require.NoError(t, err)
243248

244249
err = u.ensureIngestrInstalled(ctx, []string{"duckdb"}, repo)
245-
assert.NoError(t, err)
250+
require.NoError(t, err)
246251

247252
err = u.ensureIngestrInstalled(ctx, []string{"pyodbc", "duckdb"}, repo)
248-
assert.NoError(t, err)
253+
require.NoError(t, err)
249254

250255
assert.Equal(t, int32(3), installCount.Load(), "ingestr should be installed once for each unique package combination")
251256
}
252257

253258
func Test_ensureIngestrInstalled_ConcurrentCalls(t *testing.T) {
259+
t.Parallel()
260+
254261
ResetIngestrInstallCache()
255262
defer ResetIngestrInstallCache()
256263

@@ -273,7 +280,7 @@ func Test_ensureIngestrInstalled_ConcurrentCalls(t *testing.T) {
273280
binaryFullPath: "~/.bruin/uv",
274281
}
275282

276-
ctx := context.Background()
283+
ctx := t.Context()
277284
extraPackages := []string{"pyodbc"}
278285

279286
var wg sync.WaitGroup

0 commit comments

Comments
 (0)