Skip to content

Commit b483017

Browse files
committed
Upgrade dependencies and python of Broadworks OCIP library
1 parent 47ba1e0 commit b483017

6 files changed

Lines changed: 183 additions & 1434 deletions

File tree

.pre-commit-config.yaml

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# https://github.com/pre-commit/pre-commit-hooks/blob/master/.pre-commit-config.yaml
33
repos:
44
- repo: https://github.com/pre-commit/pre-commit-hooks
5-
rev: v4.5.0
5+
rev: v5.0.0
66
hooks:
77
- id: trailing-whitespace
88
- id: end-of-file-fixer
@@ -36,7 +36,7 @@ repos:
3636
# Ruff is an extremely fast Python linter and formatter, written in Rust. It is intended to replace Flake8, isort,
3737
# pydocstyle, yesqa, eradicate, pyupgrade, autoflake, and black.
3838
- repo: https://github.com/charliermarsh/ruff-pre-commit
39-
rev: v0.3.4
39+
rev: v0.12.4
4040
hooks:
4141
- id: ruff
4242
args: [--fix]
@@ -48,30 +48,21 @@ repos:
4848
- id: validate_manifest
4949

5050
- repo: https://github.com/asottile/pyupgrade
51-
rev: v3.15.2
51+
rev: v3.20.0
5252
hooks:
5353
- id: pyupgrade
54-
args: [--py36-plus]
54+
args: [--py38-plus]
5555

5656
- repo: https://github.com/asottile/add-trailing-comma
57-
rev: v3.1.0
57+
rev: v3.2.0
5858
hooks:
5959
- id: add-trailing-comma
60-
args: [--py36-plus]
6160

6261
- repo: https://github.com/pre-commit/mirrors-mypy
63-
rev: v1.9.0
62+
rev: v1.17.0
6463
hooks:
6564
- id: mypy
66-
additional_dependencies: [types-all, types-attrs]
67-
68-
- repo: https://github.com/pre-commit/mirrors-prettier
69-
rev: "v3.1.0"
70-
hooks:
71-
- id: prettier
72-
exclude_types: [html]
73-
stages: [commit]
74-
exclude: "docs/api|CHANGELOG.md" # huge files break prettier, autogenerated files can be problematic
65+
additional_dependencies: [types-attrs]
7566

7667
- repo: https://github.com/jumanjihouse/pre-commit-hooks
7768
rev: 3.0.0 # or specific git tag

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
---
1313

14-
> [!NOTE]
14+
> [!NOTE]
1515
> I no longer have time or access to Broadworks to be able to maintain this package.
1616
> If you would like to take it on let me know.
1717
> For now I am archiving the respository to make it clear that this now unmaintained.

broadworks_ocip/base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -282,9 +282,9 @@ def etree_sub_element_(
282282
sub_element.xmlname,
283283
nsmap=self._default_nsmap(),
284284
)
285-
if sub_element.type == bool:
285+
if sub_element.type is bool:
286286
elem.text = "true" if value else "false"
287-
elif sub_element.type == int:
287+
elif sub_element.type is int:
288288
elem.text = str(value)
289289
else:
290290
elem.text = value
@@ -393,7 +393,7 @@ def build_from_node_(
393393
)
394394
else:
395395
return elem.type.build_from_etree_(api=api, element=node)
396-
elif elem.type == bool:
396+
elif elem.type is bool:
397397
return elem.type(
398398
True if node.text == "true" else False,
399399
)

0 commit comments

Comments
 (0)