-
Notifications
You must be signed in to change notification settings - Fork 31
use useFirstPaint to control animation in Checkbox and Radio #2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d2dee8e
new useIsFirstRender
clxandstuff cdd935c
use isomorphic layout effect in useIsFirstRender
clxandstuff c7f2457
use ref in useIsFirstRender instead of state
clxandstuff 3e3cdbb
Merge branch 'master' into DS-5347-radio-animation-is-not-fired
clxandstuff b62d4d1
refactor isFirstRender
clxandstuff 26ad7f1
Merge branch 'DS-5347-radio-animation-is-not-fired' of github.com:bra…
clxandstuff 8d2688b
rename useIsFirstRender to useIsAfterFirstPaint
clxandstuff 89a5786
replace useIsAfterFirstPaint with useFirstPaint hook
clxandstuff 6fcb185
add description to story
clxandstuff c33dd5d
clean up
clxandstuff 6536c54
clean up
clxandstuff 40a608c
update useFirstPaint story
clxandstuff 19362b1
Merge branch 'DS-5347-radio-animation-is-not-fired' of github.com:bra…
clxandstuff c6ad600
use callback in useFirstPaint
clxandstuff 6c3eebe
fix example code
clxandstuff c7664f9
update Checkbox and Radio after last changes
clxandstuff 75f0e33
Merge branch 'master' into DS-5347-radio-animation-is-not-fired
clxandstuff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,17 @@ | ||
| import {useRef} from 'react'; | ||
| import React from 'react'; | ||
|
|
||
| const useIsFirstRender = () => { | ||
| const isFirstRender = useRef(true); | ||
| export const useIsFirstRender = () => { | ||
| const [isFirstRender, setIsFirstRender] = React.useState(true); | ||
|
|
||
| if (isFirstRender.current === true) { | ||
| isFirstRender.current = false; | ||
| return true; | ||
| } | ||
| React.useLayoutEffect(() => { | ||
| const raf = window.requestAnimationFrame(() => { | ||
| setIsFirstRender(false); | ||
| }); | ||
|
|
||
| return isFirstRender.current; | ||
| }; | ||
| return () => { | ||
| window.cancelAnimationFrame(raf); | ||
| }; | ||
| }, []); | ||
|
|
||
| export default useIsFirstRender; | ||
| return isFirstRender; | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @clxandstuff , we need isomorphic version here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done