use useFirstPaint to control animation in Checkbox and Radio #2744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useIsFirstRender rewritten and used in Checkbox and Radio
coderitual
reviewed
May 11, 2023
| isFirstRender.current = false; | ||
| return true; | ||
| } | ||
| React.useLayoutEffect(() => { |
Contributor
There was a problem hiding this comment.
hey @clxandstuff , we need isomorphic version here
Contributor
|
i see that you're still using state to communicate about first render (inside first render hook). I think this may cause some unexpected side effects. Let's take a look into tests. |
Contributor
Author
|
Take a look now. I removed states related to animation from |
…inly/style-guide into DS-5347-radio-animation-is-not-fired
Contributor
|
thx @clxandstuff , could you please add separate story documentation for is first render hook specifically |
clxandstuff
changed the title
…inly/style-guide into DS-5347-radio-animation-is-not-fired
Contributor
|
hey @clxandstuff I see 2 problems with the example below:
|
coderitual
approved these changes
May 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new hook
useFirstPaintto replaceuseIsFirstRender. It checks whether the component render function has triggered the first paint of DOM.It has been used in Checkbox and Radio to prevent animation on the initial render and to replace the
isPristineflag.