Skip to content

Conversation

@domidomi
Copy link
Contributor

@domidomi domidomi commented Apr 18, 2023

  • Do not block pointer events on touch screens so triggers work properly
  • Fix popup position
  • Fix focus management
  • Indicate hover on checkbox when hovering option

@domidomi domidomi requested a review from a team as a code owner April 18, 2023 07:22
@coderitual
Copy link
Contributor

thanks @domidomi I will take a look tomorrow morning.

@coderitual
Copy link
Contributor

Hey @domidomi couple issues here:

  • documentation should always start from presenting component (I am referring to the comment about component being controlled)
  • In default story i cannot select item
  • There is something wrong with positioning of the popup on our docs page

I will get back to the mobile testing once those are addressed.

CleanShot.2023-04-27.at.09.13.30.mp4

@domidomi
Copy link
Contributor Author

Hey @domidomi couple issues here:

  • documentation should always start from presenting component (I am referring to the comment about component being controlled)
  • In default story i cannot select item
  • There is something wrong with positioning of the popup on our docs page

I will get back to the mobile testing once those are addressed.

CleanShot.2023-04-27.at.09.13.30.mp4

@coderitual All fixed now!

@coderitual
Copy link
Contributor

coderitual commented May 11, 2023

hey @domidomi I found 2 issues on desktop

  • not enough space around component in stories
    CleanShot 2023-05-11 at 12 52 59

  • When using keyboard, there is some jump during animation

CleanShot.2023-05-11.at.12.54.12.mp4

And one on mobile:

  • select button/input changes color in different ways depending how popup was closed (touch vs scroll)
RPReplay_Final1683817381.mp4

Copy link
Contributor

@coderitual coderitual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @domidomi , issues from my comment #2721 (comment) can be fixed in separate PR. Let's merge this one so we can double check if everything is ok on form component.

@domidomi domidomi merged commit 6653620 into master May 30, 2023
@domidomi domidomi deleted the select-menu-mobile-bugfixes branch May 30, 2023 12:18
@domidomi domidomi mentioned this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants