Skip to content

Commit e8691ab

Browse files
Skip route group immutable test (sonic-net#3393)
What I did Skip VS test dash/test_dash_route_group.py::test_bound_route_group_immutable Why I did it This test causes orchagent to crash since the VS SAI has not been updated to include implicit deletion of high-volume DASH objects (https://github.com/sonic-net/SONiC/blob/master/doc/dash/dash-sonic-hld.md#18-implicit-deletion-of-sai-objects)
1 parent 9ec5e13 commit e8691ab

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

tests/dash/test_dash_route_group.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
APP_DASH_ROUTE_GROUP_TABLE_NAME,
1616
)
1717

18+
1819
@pytest.fixture(autouse=True)
1920
def common_setup_teardown(dash_db: DashDB):
2021
dash_db.set_app_db_entry(APP_DASH_APPLIANCE_TABLE_NAME, APPLIANCE_ID, APPLIANCE_CONFIG)
@@ -37,6 +38,7 @@ def common_setup_teardown(dash_db: DashDB):
3738
dash_db.remove_app_db_entry(APP_DASH_ROUTING_TYPE_TABLE_NAME, PRIVATELINK)
3839
dash_db.remove_app_db_entry(APP_DASH_APPLIANCE_TABLE_NAME, APPLIANCE_ID)
3940

41+
4042
def test_rebind_eni_route_group(dash_db: DashDB):
4143
dash_db.set_app_db_entry(APP_DASH_ROUTE_GROUP_TABLE_NAME, ROUTE_GROUP1, ROUTE_GROUP1_CONFIG)
4244
dash_db.set_app_db_entry(APP_DASH_ROUTE_TABLE_NAME, ROUTE_GROUP1, OUTBOUND_ROUTE_PREFIX1, ROUTE_VNET_CONFIG)
@@ -58,6 +60,7 @@ def test_rebind_eni_route_group(dash_db: DashDB):
5860
dash_db.set_app_db_entry(APP_DASH_ENI_ROUTE_TABLE_NAME, ENI_ID, ENI_ROUTE_GROUP2_CONFIG)
5961
dash_db.wait_for_asic_db_field("ASIC_STATE:SAI_OBJECT_TYPE_ENI", eni_key, SAI_ENI_ATTR_OUTBOUND_ROUTING_GROUP_ID, rg2_oid)
6062

63+
6164
def test_duplicate_eni_route_group(dash_db: DashDB):
6265
dash_db.set_app_db_entry(APP_DASH_ROUTE_GROUP_TABLE_NAME, ROUTE_GROUP1, ROUTE_GROUP1_CONFIG)
6366
dash_db.set_app_db_entry(APP_DASH_ROUTE_TABLE_NAME, ROUTE_GROUP1, OUTBOUND_ROUTE_PREFIX1, ROUTE_VNET_CONFIG)
@@ -71,6 +74,8 @@ def test_duplicate_eni_route_group(dash_db: DashDB):
7174
dash_db.set_app_db_entry(APP_DASH_ENI_ROUTE_TABLE_NAME, ENI_ID, ENI_ROUTE_GROUP1_CONFIG)
7275
dash_db.wait_for_asic_db_field("ASIC_STATE:SAI_OBJECT_TYPE_ENI", eni_key, SAI_ENI_ATTR_OUTBOUND_ROUTING_GROUP_ID, rg1_oid)
7376

77+
78+
@pytest.mark.skip(reason="Test will crash orchagent until VS SAI is updated with implicit deletion for DASH objects")
7479
def test_bound_route_group_immutable(dash_db: DashDB):
7580
dash_db.set_app_db_entry(APP_DASH_ROUTE_GROUP_TABLE_NAME, ROUTE_GROUP1, ROUTE_GROUP1_CONFIG)
7681
num_route_groups = len(dash_db.wait_for_asic_db_keys("ASIC_STATE:SAI_OBJECT_TYPE_OUTBOUND_ROUTING_GROUP"))

0 commit comments

Comments
 (0)