Added SVG validation: width and height must be specified #2195 #2062

Author: liborm85

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 - Fixed non-working `open()` and `print()` methods in browser
+- Added SVG validation: width and height must be specified (in SVG string/element or `svg` node)
 
 ## 0.3.1 - 2026-01-07
 

src/DocMeasure.js

@@ -154,6 +154,15 @@ class DocMeasure {
 
 		node.font = this.styleStack.getProperty('font');
 
+		// SVG requires a defined width and height
+		if (!isNumber(node._width) && !isNumber(node._height)) {
+			throw new Error('SVG is missing defined width and height.');
+		} else if (!isNumber(node._width)) {
+			throw new Error('SVG is missing defined width.');
+		} else if (!isNumber(node._height)) {
+			throw new Error('SVG is missing defined height.');
+		}
+
 		// scale SVG based on final dimension
 		node.svg = this.svgMeasure.writeDimensions(node.svg, { width: node._width, height: node._height });
 

src/helpers/variableType.js

@@ -11,7 +11,7 @@ export function isString(variable) {
  * @returns {boolean}
  */
 export function isNumber(variable) {
-	return (typeof variable === 'number') || (variable instanceof Number);
+	return ((typeof variable === 'number') || (variable instanceof Number)) && !Number.isNaN(variable);
 }
 
 /**

tests/unit/helpers/variableType.spec.js

@@ -44,6 +44,10 @@ const variableCheckMap = [
 		value: new Number(78),
 		type: [isNumber, isValue]
 	},
+	{
+		value: NaN,
+		type: [isValue]
+	},
 	{
 		value: true,
 		type: [isValue]