Skip to content

Update set_credentials to no longer pass aws_account_id #4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

Update set_credentials to no longer pass aws_account_id #4586

merged 1 commit into from
Aug 6, 2025

Conversation

@nateprewitt
Copy link
Contributor

@nateprewitt nateprewitt commented Aug 6, 2025

Update call to set_credentials to only pass aws_account_id when explicitly set similar to #4585.

@nateprewitt nateprewitt marked this pull request as ready for review August 6, 2025 05:50
@nateprewitt nateprewitt requested a review from jonathan343 August 6, 2025 14:49
@nateprewitt nateprewitt merged commit beb14ee into develop Aug 6, 2025
76 checks passed
@nateprewitt nateprewitt deleted the account_id_set_creds branch August 6, 2025 15:00
aws-sdk-python-automation added a commit that referenced this pull request Aug 6, 2025
@aws-sdk-python-automation
Merge branch 'release-1.40.4'
b7bfc90 
* release-1.40.4:
  Bumping version to 1.40.4
  Add changelog entries from botocore
  Update set_credentials to no longer pass aws_account_id (#4586)
  Only pass aws_account_id to botocore when explicitly set (#4585)
hswong3i pushed a commit to alvistack/boto-boto3 that referenced this pull request Aug 7, 2025
@nateprewitt @hswong3i
Update set_credentials to no longer pass aws_account_id (boto#4586)
47ecd56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathan343 jonathan343 jonathan343 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nateprewitt @jonathan343