This normalizes the code issue generation #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psalm expects plugin issues to be thrown by plugins. We did it wrong in the earlier releases and re-used existing issues. Somehow, these issues were not properly suppressed - probably due to the `IssueBuffer#add` usage rather than `IssueBuffer#maybeAdd`. Signed-off-by: Maximilian Bösing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Psalm expects plugin issues to be thrown by plugins. We did it wrong in the earlier releases and re-used existing issues. Somehow, these issues were not properly suppressed - probably due to the
IssueBuffer#addusage rather thanIssueBuffer#maybeAdd.