Skip to content

Commit f34f46b

Browse files
authored
fix(core): Don’t error if turn.order.next returns undefined (#614)
* fix(core): Don’t error if turn.next returns undefined * fix(core): Mention in `turn.order.next` error that undefined is OK
1 parent 45f4f43 commit f34f46b

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/core/turn-order.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,9 +289,9 @@ export function UpdateTurnOrderState(
289289
} else {
290290
const t = order.next(G, ctx);
291291
const type = typeof t;
292-
if (type !== 'number') {
292+
if (t !== undefined && type !== 'number') {
293293
logging.error(
294-
`invalid value returned by turn.order.next — expected number got ${type}${t}”.`
294+
`invalid value returned by turn.order.next — expected number or undefined, got ${type}${t}”.`
295295
);
296296
}
297297

src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ export interface StageMap {
159159

160160
export interface TurnOrderConfig {
161161
first: (G: any, ctx: Ctx) => number;
162-
next: (G: any, ctx: Ctx) => number;
162+
next: (G: any, ctx: Ctx) => number | undefined;
163163
playOrder?: (G: any, ctx: Ctx) => PlayerID[];
164164
}
165165

0 commit comments

Comments
 (0)