allow to modify actionPlayers via Events (#157)

* allow to modify actionPlayers via Events

* minor style tweak

* remove trailing whitespace

Author: Stefan-Hanke

src/client/client.test.js

@@ -77,6 +77,7 @@ test('event dispatchers', () => {
       'undo',
       'redo',
       'endTurn',
+      'changeActionPlayers',
     ]);
     expect(store.getState().ctx.turn).toBe(0);
     api.endTurn();
@@ -99,6 +100,7 @@ test('event dispatchers', () => {
       'endTurn',
       'endPhase',
       'endGame',
+      'changeActionPlayers',
     ]);
     expect(store.getState().ctx.turn).toBe(0);
     api.endTurn();
@@ -118,7 +120,7 @@ test('event dispatchers', () => {
     const reducer = createGameReducer({ game, numPlayers: 2 });
     const store = createStore(reducer);
     const api = createEventDispatchers(game.flow.eventNames, store);
-    expect(Object.getOwnPropertyNames(api)).toEqual([]);
+    expect(Object.getOwnPropertyNames(api)).toEqual(['changeActionPlayers']);
   }
 
   {
@@ -136,6 +138,7 @@ test('event dispatchers', () => {
       'redo',
       'endTurn',
       'endPhase',
+      'changeActionPlayers',
     ]);
     expect(store.getState().ctx.turn).toBe(0);
     api.endTurn();

src/core/flow.js

@@ -563,6 +563,10 @@ export function FlowWithPhases({
   if (endPhase) enabledEvents['endPhase'] = endPhaseEvent;
   if (endGame) enabledEvents['endGame'] = endGameEvent;
 
+  enabledEvents['changeActionPlayers'] = (state, actionPlayers) => {
+    return { G: state.G, ctx: { ...state.ctx, actionPlayers } };
+  };
+
   return Flow({
     ctx: numPlayers => ({
       numPlayers,

src/core/flow.test.js

@@ -617,3 +617,61 @@ test('endGame', () => {
     expect(t.ctx.gameover).toBe(42);
   }
 });
+
+test('change action players', () => {
+  const flow = FlowWithPhases({});
+  const state = { ctx: {} };
+  const newState = flow.processGameEvent(state, {
+    type: 'changeActionPlayers',
+    args: [[1, 2]],
+  });
+  expect(newState.ctx.actionPlayers).toMatchObject([1, 2]);
+});
+
+test('change action players - reducer', () => {
+  let game = Game({
+    moves: {
+      playMilitia: (G, ctx) => {
+        // change which players need to act
+        ctx.events.changeActionPlayers([1, 2, 3]);
+        return { ...G, playedCard: 'Militia' };
+      },
+      dropCards: (G, ctx) => {
+        if (G.playedCard === 'Militia') {
+          let actedOnMilitia = G.actedOnMilitia || [];
+          actedOnMilitia.push(ctx.playerID);
+
+          // this player did drop and must not take another action.
+          var newActionPlayers = [...ctx.actionPlayers].filter(
+            pn => pn !== ctx.playerID
+          );
+          ctx.events.changeActionPlayers(newActionPlayers);
+
+          let playedCard = G.playedCard;
+          if (actedOnMilitia.length === 3) {
+            ctx.events.changeActionPlayers([0]);
+            actedOnMilitia = undefined;
+            playedCard = undefined;
+          }
+          return { ...G, actedOnMilitia, playedCard };
+        } else {
+          return G;
+        }
+      },
+    },
+  });
+
+  const reducer = createGameReducer({ game, numPlayers: 4 });
+
+  let state = reducer(undefined, { type: 'init' });
+  state = reducer(state, makeMove('playMilitia'));
+  expect(state.ctx.actionPlayers).toMatchObject([1, 2, 3]);
+
+  state = reducer(state, makeMove('dropCards', undefined, 1));
+  expect(state.ctx.actionPlayers).toMatchObject([2, 3]);
+  state = reducer(state, makeMove('dropCards', undefined, 3));
+  expect(state.ctx.actionPlayers).toMatchObject([2]);
+  state = reducer(state, makeMove('dropCards', undefined, 2));
+  expect(state.ctx.actionPlayers).toMatchObject([0]);
+  expect(state.G).toMatchObject({});
+});