fix bug in the way the transport notifies client subscribers of connection changes

Author: nicolodavis

src/client/client.js

@@ -351,7 +351,7 @@ class _ClientImpl {
   subscribe(fn) {
     const id = Object.keys(this.subscribers).length;
     this.subscribers[id] = fn;
-    this.transport.subscribe(this.notifySubscribers);
+    this.transport.subscribe(() => this.notifySubscribers());
     this.notifySubscribers();
 
     // Return a handle that allows the caller to unsubscribe.

src/client/client.test.js

@@ -631,6 +631,19 @@ describe('subscribe', () => {
     );
     expect(fn2).not.toBeCalled();
   });
+
+  test('transport notifies subscribers', () => {
+    const client = Client({
+      game: {},
+      multiplayer: true,
+    });
+    const fn = jest.fn();
+    client.subscribe(fn);
+    client.start();
+    fn.mockClear();
+    client.transport.callback();
+    expect(fn).toHaveBeenCalled();
+  });
 });
 
 test('override game state', () => {