Workaround non-batch geth requests
#134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain nodes do not support batch requests for
debug_traceBlockByNumber, which is used by export_geth_traces.Rather than adding a non-batch executor, this PR provides a workaround where the existing
BatchWeb3Provideris used to send a non-batch request ifbatch_size == 1and the response is then appended to a list, to mimic the response of a batch request.In order to make this workaround complete, I've also updated the MockBatchWeb3Provider used in tests. Local tests have been run successfully with a variety of node providers.