Skip to content

Commit a70a8a5

Browse files
r-barnesfacebook-github-bot
authored andcommitted
Remove unused variables in faiss/impl/HNSW.cpp
Summary: LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: algoriddle Differential Revision: D52981042 fbshipit-source-id: 6748dc957a26a6b5dec3922505c18a1996e3a002
1 parent b274cb4 commit a70a8a5

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

faiss/impl/HNSW.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -851,13 +851,11 @@ HNSWStats HNSW::search(
851851
top_candidates.pop();
852852
}
853853

854-
int nres = 0;
855854
while (!top_candidates.empty()) {
856855
float d;
857856
storage_idx_t label;
858857
std::tie(d, label) = top_candidates.top();
859858
res.add_result(d, label);
860-
nres++;
861859
top_candidates.pop();
862860
}
863861
}

0 commit comments

Comments
 (0)