Skip to content

Commit 9a1b5c4

Browse files
committed
Fix some PS replacements
1 parent cfce83e commit 9a1b5c4

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

wled00/FX.cpp

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1861,6 +1861,7 @@ uint16_t mode_palette() {
18611861
static const char _data_FX_MODE_PALETTE[] PROGMEM = "Palette@Shift,Size,Rotation,,,Animate Shift,Animate Rotation,Anamorphic;;!;12;c1=128,c2=128,c3=128,o1=1,o2=0,o3=0";
18621862

18631863

1864+
#if !defined(WLED_PS_REPLACE_FX) || defined(WLED_DISABLE_PARTICLESYSTEM1D)
18641865
// WLED limitation: Analog Clock overlay will NOT work when Fire2012 is active
18651866
// Fire2012 by Mark Kriegsman, July 2012
18661867
// as part of "Five Elements" shown here: http://youtu.be/knWiGsmgycY
@@ -1950,6 +1951,8 @@ uint16_t mode_fire_2012() {
19501951
return FRAMETIME;
19511952
}
19521953
static const char _data_FX_MODE_FIRE_2012[] PROGMEM = "Fire 2012@Cooling,Spark rate,,2D Blur,Boost;;!;1;pal=35,sx=64,ix=160,m12=1,c2=128"; // bars
1954+
#endif
1955+
19531956

19541957
// colored stripes pulsing at a defined Beats-Per-Minute (BPM)
19551958
uint16_t mode_bpm() {
@@ -2669,6 +2672,7 @@ uint16_t mode_spots()
26692672
static const char _data_FX_MODE_SPOTS[] PROGMEM = "Spots@Spread,Width,,,,Fade;!,!;!;1;";
26702673

26712674

2675+
#if !defined(WLED_PS_REPLACE_FX) || defined(WLED_DISABLE_PARTICLESYSTEM1D)
26722676
//each needs 12 bytes
26732677
typedef struct Ball {
26742678
unsigned long lastBounceTime;
@@ -2749,6 +2753,7 @@ uint16_t mode_bouncing_balls(void) {
27492753
return FRAMETIME;
27502754
}
27512755
static const char _data_FX_MODE_BOUNCINGBALLS[] PROGMEM = "Bouncing Balls@Gravity,# of balls;1,2,3;!;1;m12=1"; //bar
2756+
#endif
27522757

27532758

27542759
/*
@@ -2890,9 +2895,9 @@ uint16_t mode_sinelon() {
28902895
static const char _data_FX_MODE_SINELON[] PROGMEM = "Sinelon@!,Trail,,,,Rainbow,,Dual;!,!,!;!";
28912896

28922897

2898+
#if !defined(WLED_PS_REPLACE_FX) || defined(WLED_DISABLE_PARTICLESYSTEM1D)
28932899
//Glitter with palette background, inspired by https://gist.github.com/kriegsman/062e10f7f07ba8518af6
2894-
uint16_t mode_glitter()
2895-
{
2900+
uint16_t mode_glitter() {
28962901
// use "* Color 1" palette for solid background (replacing "Solid glitter")
28972902
unsigned counter = 0;
28982903
if (SEGMENT.speed != 0) {
@@ -2908,6 +2913,7 @@ uint16_t mode_glitter()
29082913
return FRAMETIME;
29092914
}
29102915
static const char _data_FX_MODE_GLITTER[] PROGMEM = "Glitter@!,!;,,Glitter color;!;;pal=11,m12=0"; //pixels
2916+
#endif
29112917

29122918

29132919
//each needs 20 bytes
@@ -8842,7 +8848,9 @@ void WS2812FX::setupEffectData() {
88428848
addEffect(FX_MODE_STATIC_PATTERN, &mode_static_pattern, _data_FX_MODE_STATIC_PATTERN);
88438849
addEffect(FX_MODE_TRI_STATIC_PATTERN, &mode_tri_static_pattern, _data_FX_MODE_TRI_STATIC_PATTERN);
88448850
addEffect(FX_MODE_SPOTS, &mode_spots, _data_FX_MODE_SPOTS);
8851+
#if !defined(WLED_PS_REPLACE_FX) || defined(WLED_DISABLE_PARTICLESYSTEM1D)
88458852
addEffect(FX_MODE_GLITTER, &mode_glitter, _data_FX_MODE_GLITTER);
8853+
#endif
88468854
addEffect(FX_MODE_CANDLE, &mode_candle, _data_FX_MODE_CANDLE);
88478855
#if !defined(WLED_PS_REPLACE_FX) || defined(WLED_DISABLE_PARTICLESYSTEM1D)
88488856
addEffect(FX_MODE_STARBURST, &mode_starburst, _data_FX_MODE_STARBURST);
@@ -8876,7 +8884,7 @@ void WS2812FX::setupEffectData() {
88768884
addEffect(FX_MODE_WAVESINS, &mode_wavesins, _data_FX_MODE_WAVESINS);
88778885
#ifndef WLED_DISABLE_PARTICLESYSTEM1D
88788886
addEffect(FX_MODE_PS1DDRIP, &mode_particleDrip, _data_FX_MODE_PS1DDRIP);
8879-
addEffect(FX_MODE_PS1DPINBALL, &mode_particlePinball, _data_FX_MODE_PS1DPINBALL); //potential replacement for: bouncing balls, rollingballs, popcorn
8887+
addEffect(FX_MODE_PS1DPINBALL, &mode_particlePinball, _data_FX_MODE_PS1DPINBALL);
88808888
addEffect(FX_MODE_PS1DDANCINGSHADOWS, &mode_particleDancingShadows, _data_FX_MODE_PS1DDANCINGSHADOWS);
88818889
addEffect(FX_MODE_PS1DFIREWORKS, &mode_particleFireworks1D, _data_FX_MODE_PS1DFIREWORKS);
88828890
addEffect(FX_MODE_PS1DSPARKLER, &mode_particleSparkler, _data_FX_MODE_PS1DSPARKLER);

wled00/FX.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,6 @@ extern byte realtimeMode; // used in getMappedPixelIndex()
321321
#endif
322322
// particle 1D
323323
#ifndef WLED_DISABLE_PARTICLESYSTEM1D
324-
#define FX_MODE_PS1DSPARKLER 16
325324
#define FX_MODE_PS1DHOURGLASS 19
326325
#define FX_MODE_PS1DSPRAY 23
327326
#define FX_MODE_PS1DBALANCE 24
@@ -334,18 +333,21 @@ extern byte realtimeMode; // used in getMappedPixelIndex()
334333
#define FX_MODE_PS1DCHASE 28
335334
#define FX_MODE_PS1DSTARBURST 89
336335
#define FX_MODE_PS1DFIRE 66
336+
#define FX_MODE_PS1DSPARKLER 87
337337
#undef FX_MODE_DRIP
338338
#undef FX_MODE_BOUNCING_BALLS
339339
#undef FX_MODE_DANCING_SHADOWS
340340
#undef FX_MODE_EXPLODING_FIREWORKS
341341
#undef FX_MODE_CHASE
342342
#undef FX_MODE_STARBURST
343343
#undef FX_MODE_FIRE_2012
344+
#undef FX_MODE_GLITTER
344345
#else
345346
#define FX_MODE_PS1DDRIP 4
346347
#define FX_MODE_PS1DPINBALL 6
347348
#define FX_MODE_PS1DDANCINGSHADOWS 11
348349
#define FX_MODE_PS1DFIREWORKS 14
350+
#define FX_MODE_PS1DSPARKLER 16
349351
#define FX_MODE_PS1DCHASE 26
350352
#define FX_MODE_PS1DSTARBURST 29
351353
#define FX_MODE_PS1DFIRE 33

0 commit comments

Comments
 (0)