various small fixes

Author: liquidsec

bbot/modules/retirejs.py

@@ -186,6 +186,7 @@ async def handle_event(self, event):
                                     "name": "Vulnerable JavaScript Library",
                                     "description": description,
                                     "severity": severity,
+                                    "confidence": "HIGH",
                                     "component": component,
                                     "url": event.parent.data["url"],
                                 }

bbot/test/test_step_2/module_tests/test_module_slack.py

@@ -4,4 +4,4 @@
 class TestSlack(DiscordBase):
     modules_overrides = ["slack", "excavate", "badsecrets", "httpx"]
     webhook_url = "https://hooks.slack.com/services/deadbeef/deadbeef/deadbeef"
-    config_overrides = {"modules": {"slack": {"webhook_url": webhook_url}}}
+    config_overrides = {"modules": {"slack": {"webhook_url": webhook_url, "min_severity": "INFORMATIONAL"}}}

bbot/test/test_step_2/module_tests/test_module_teams.py

@@ -7,7 +7,7 @@ class TestTeams(DiscordBase):
     modules_overrides = ["teams", "excavate", "badsecrets", "httpx"]
 
     webhook_url = "https://evilcorp.webhook.office.com/webhookb2/deadbeef@deadbeef/IncomingWebhook/deadbeef/deadbeef"
-    config_overrides = {"modules": {"teams": {"webhook_url": webhook_url, "retries": 5}}}
+    config_overrides = {"modules": {"teams": {"webhook_url": webhook_url, "retries": 5, "min_severity": "INFORMATIONAL"}}}
 
     async def setup_after_prep(self, module_test):
         self.custom_setup(module_test)
@@ -32,8 +32,6 @@ def custom_response(request: httpx.Request):
         module_test.httpx_mock.add_callback(custom_response, url=self.webhook_url)
 
     def check(self, module_test, events):
-        vulns = [e for e in events if e.type == "FINDING"]
         findings = [e for e in events if e.type == "FINDING"]
-        assert len(findings) == 1
-        assert len(vulns) == 2
+        assert len(findings) == 3
         assert module_test.request_count == 5