-
Notifications
You must be signed in to change notification settings - Fork 412
chore(ci): pin proptest to 1.8.0 on 1.75.0 MSRV
#2075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): pin proptest to 1.8.0 on 1.75.0 MSRV
#2075
Conversation
|
I wasn't expecting all these dependencies needing to be pinned for the Also, let me know if you think all squashed down to a single commit would be better, I just need this to move forward with #2027. |
chore(ci): pin `proptest` to `1.8.0` on `1.75.0` MSRV chore(ci): pin `[email protected]` instead of `1.0.3` chore(ci): pin `[email protected]` instead of `0.6.0` chore(ci): pin `quote` to `1.0.41` chore(ci): pin `syn` to `2.0.106` chore(ci): pin `openssl` to `0.10.73` chore(ci): pin `openssl-sys` to `0.9.109`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 62ce876 No need to squash IMO.
luisschwab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 62ce876
822ce5e
into
bitcoindevkit:release/chain-0.23.x
Description
The
proptestdependency is used inbdk_chain, it's already pinned to1.2.0on1.63.0MSRV, and wasn't a problem on the1.75.0MSRV. Recently, it also released a new version, bumping their MSRV, onproptest 1.9.0.It adds a new step to pin it to
1.8.0on the1.75.0MSRV CI step.edit: I also had to update the pinned version
[email protected]and[email protected].Notes to the reviewers
It only applies to
release/chain-0.23.xbranch; the master is already on1.85.0MSRV, which is not affected.Changelog notice
Checklists
All Submissions: