Remove TxBuilder allow_shrinking() and unneeded context param#1386
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom May 23, 2024
Merged
Conversation
notmandatory
added
bug
notmandatory
force-pushed
the
fix/remove_allow_shrinking
branch
from
7abec98 to
b51fa22
Compare
Member
Author
|
@LLFourn I did a little more than just remove TxBuilder::allow_shrinking in this PR. If you think it's too much to remove the TxBuilder context I can put it back in, but then I'll need to either remove the two tests I updated or add the functions I needed to work for either context. |
notmandatory
force-pushed
the
fix/remove_allow_shrinking
branch
2 times, most recently
from
25a81fa to
4073c43
Compare
notmandatory
commented
Mar 25, 2024
Collaborator
|
LGTM Conceptually, I think |
notmandatory
force-pushed
the
fix/remove_allow_shrinking
branch
3 times, most recently
from
e35839a to
1ab9204
Compare
Collaborator
|
ACK 1ab9204 |
8 tasks
ValuedMammal
approved these changes
May 14, 2024
notmandatory
force-pushed
the
fix/remove_allow_shrinking
branch
2 times, most recently
from
f3dcb60 to
97e2508
Compare
Collaborator
|
ACK 97e2508 |
notmandatory
force-pushed
the
fix/remove_allow_shrinking
branch
from
97e2508 to
096b8ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove wallet::TxBuilder::allow_shrinking() and unneeded TxBuilder context param.
Fixes #1374
Notes to the reviewers
The allow_shrinking function was the only one using the TxBuilder FeeBump context and it's useful to have CreateTx context functions available for building FeeBump transactions, see updated tests.
Changelog notice
Changed
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: