fix: ensure proxy support and bump anthropic dependency #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
fix issue #699 |
jinzhuer
changed the title
Author
|
@kartik4949 this PR fixes Curator ignoring system proxies by enabling trust_env=True on the aiohttp.ClientSession and bumps the anthropic SDK. No behavioral change except honoring HTTP(S)_PROXY. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
Curator’s aiohttp.ClientSession was created without trust_env=True, so it ignored HTTP(S)_PROXY.
Older anthropic SDK versions didn’t provide robust proxy support, so Anthropic calls didn’t honor the proxy.
Changes
Injected
trust_env=True)when creating theaiohttp.ClientSession, ensuring system proxy variables (HTTP(S)_PROXY,ALL_PROXY) are respected.Bumped the
anthropicdependency to a newer version that has native proxy support.