-
Notifications
You must be signed in to change notification settings - Fork 11
here is my python code implementing compute_weights function #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
whitesockcat
wants to merge
2
commits into
bes-dev:master
Choose a base branch
from
whitesockcat:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import torch | ||
|
|
||
| def compute_weights(losses, indices, weights, ratio, p): | ||
| size = losses.size(0) | ||
|
|
||
| # find first nonzero element | ||
| pos = 0 | ||
| while losses[pos]< 1e-5: | ||
| pos += 1 | ||
| n = size - pos | ||
| m = int(ratio * n) | ||
| if n <= 0 or m <= 0: | ||
| raise ValueError | ||
| q = p / (p - 1.0) | ||
| c = m - n + 1 | ||
| a = [0.0 , 0.0] | ||
| i = pos | ||
| nu = 0.0 | ||
| while i < n and nu < 1e-5: | ||
| loss_q = (losses[i] / losses[size - 1]) ** q | ||
| a[0] = a[1] | ||
| a[1] += loss_q | ||
| c += 1 | ||
| nu = c * loss_q - a[1] | ||
|
|
||
| # compute alpha | ||
| if nu < 1e-5: | ||
| i += 1 | ||
| c += 1 | ||
| a[0] = a[1] | ||
| alpha = (a[0] / c) ** (1 / q) * losses[size - 1] | ||
|
|
||
| # compute_weights | ||
| tau = 1.0 / (n ** (1.0 / q)*(m **(1.0 / p))) | ||
| k = i | ||
| while k < n: | ||
| # maybe wrong | ||
| weights[indices[k]] = tau | ||
| k += 1 | ||
| if alpha > -1e-5: | ||
| k = pos | ||
| while k < i: | ||
| weights[indices[k]] = tau * (losses[k] / alpha) ** (q - 1) | ||
| k += 1 | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, the main reason for implement compute_weight in C++ is that python's loops are too slow and this loop will be a too slow for large batch size. Can you provide performance report which show that python code isn't slower than c++ implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. However i haven't compared yet. Thanks for your patience again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cann't run build.py. So i try the python version , but it doesn't work. Have you succeed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@01lin currently this implementation is not compatible with pytorch 0.5+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@belbes With pytorch 0.4.0 and python3, I also cann't run build.py. And the error is " cffi.error.VerificationError: CompileError: command 'gcc' failed with exit status 1". Can you help me?