Skip to content

Conversation

@ReadyPlayerNaN
Copy link

New rule checks against importing from the current file. Ref #447.

First time working with eslint rules. Please review.

New rule checks against importing from the current file. Ref #447
@coveralls
Copy link

coveralls commented Jul 21, 2016

Coverage Status

Coverage increased (+0.02%) to 97.662% when pulling 85b2e71 on just-paja:feature/no-self-import into 6e12c9e on benmosher:master.

@benmosher
Copy link
Member

I think this rule should leverage the resolve infrastructure.

At least, if resolve comes back non-null, then the result should be compared with context.getFilename(). Then the resolver is responsible for things like missing extensions, aliases, linklocals, etc.

@jfmengels
Copy link
Collaborator

This would be a cool rule to have!
Are you still up to work on this @just-paja? No worries if you're not :)

@ReadyPlayerNaN
Copy link
Author

Hey, sorry all, I completely forgot about this. @jfmengels, I will happily pass this to you.

@jfmengels
Copy link
Collaborator

Hey, no problem ;)
Not sure if/when I'll get to this. It's up for the taking if someone wants to have a go at it.

@giodamelio
Copy link
Contributor

If it's all right with everyone. I would like to take a crack at this one.

@jfmengels
Copy link
Collaborator

Please do @giodamelio!

@giodamelio giodamelio mentioned this pull request Jan 22, 2017
5 tasks
@giodamelio
Copy link
Contributor

Awesome, I just opened #727.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants